Repository navigation
Test infrastructure: files.list conformance check uploads nested names - #1195
Merged
Merged
Conversation
…res ls --recursive The check uploaded only flat names, so `ls --recursive` and `ls` returned the same listing and a CLI that ignored the option still passed. Upload a nested name (list/sub/d.txt): the recursive listing must contain it, and the listing without --recursive must collapse it into the folder entry list/sub/. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
sophiecarreras
commented
Nov 2, 2026
sophiecarreras
left a comment
Contributor
Author
There was a problem hiding this comment.
Review: changes only .sdkharness/tests/conformance-file-lifecycle.py and a changelog.d fragment. The files.list check now uploads two nested names and asserts that 'ls' without --recursive collapses them into one folder entry (top-level names plus list/sub/), while the recursive listing still returns all names; the versions check correctly moves to top_level[-1]. Logic is sound. The first run had two failures unrelated to the diff: test-docker test_rm_b2id (500 internal_error 'internal incident' from the B2 service) and macos test_sync_up (socket.gaierror name resolution); unit suites passed. One rerun of the failed jobs is now fully green. Merging normally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository-owned
files.listconformance check could not tell whetherls --recursivewas honoured: with flat names a CLI that ignores the option sends the same requests and the check still passed.list/sub/d.txtandlist/sub/e.txt.lsmust return the three top-level names plus the folder entrylist/sub/(read as plain text, because--jsonprints a folder as its first file).Verified at the pinned B2 simulator: the real CLI 5.0.2 passes; a mutant where
lsignores--recursivefails; a mutant wherelsis always recursive fails; the old check passed the ignore-option mutant. Test infrastructure only: no change to the CLI's behaviour.🤖 Generated with Claude Code