Repository navigation
test(base): kill surviving Gremlins mutants in wire helpers (#290) - #296
Merged
Merged
Conversation
Pin wire normalization, bucket update field presence, SSE conflicts, large-file results and checksums, and exact download range behavior with hermetic tests. Part of #290
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Part A of #290 targets the 26 surviving mutants in
base/base.goat59104c6. Existing tests leave gaps in wire mapping, branch outcomes and download boundaries.Changes
Target outcomes
All 19 behavior-changing mutants were hand-applied individually, killed by the named focused test, restored, and followed by a passing run. No Gremlins rerun was needed or performed. Source locations below refer to
59104c6; columns distinguish mutants sharing a line.CN = CONDITIONALS_NEGATION; CB = CONDITIONALS_BOUNDARY.
Equivalent / redundant mutants skipped
Each was replayed individually and the relevant tests still pass. These do not warrant tests that pin internal control flow or incidental diagnostic text.
Verification
All commands ran with B2_APPLICATION_KEY_ID, B2_APPLICATION_KEY, B2_ACCOUNT_ID and B2_ACCOUNT_KEY empty.
go build ./...— pass.go vet ./...— pass.go test -count=1 -timeout=120s ./base/...— pass.make ci— pass, including lint, race tests and cross-builds.go test -count=1 -timeout=30s ./base -run '^<named-test>$'— FAIL with the mutation, PASS after restoringbase/base.go. No compile failures or test timeouts counted as kills.Representative red → green output:
Live B2 and simulator contracts were not run: this change strengthens hermetic tests and changes no SDK behavior or harness scenario. Base wire/auth test changes require human code-owner review.
Part of #290