Add support for fixed default element namespace#2618
Merged
ChristianGruen merged 2 commits intoBaseXdb:mainfrom Mar 10, 2026
Merged
Add support for fixed default element namespace#2618ChristianGruen merged 2 commits intoBaseXdb:mainfrom
fixed default element namespace#2618ChristianGruen merged 2 commits intoBaseXdb:mainfrom
Conversation
Member
|
Looks all good. And thanks for introducing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the XQuery 4.0 feature
declare fixed default element namespace.When
fixedis declared, the default element/type namespace is no longer affected byxmlnsdeclarations on direct element constructors. To support this, the static context now distinguishes between:elemNS)dirNS)QName resolution was adjusted accordingly, and deferred QName resolution during parsing was updated to use the correct namespace context. Minor cleanups were included (avoiding entries for already-resolved QNames).
A new
NamespaceTest.fixed()test method was added to cover the new behavior. Also these QT4 tests now pass successfully:default-namespace-40-01default-namespace-40-02default-namespace-40-03default-namespace-40-04The second commit in this PR refactors
QNmCacheandQNmCheck, because their previous naming was somewhat misleading. The classes are replaced byQNmResolverthat stores deferred resolution entries in a small record. The refactoring simplifies the control flow, removes redundant checks, and makes the intent of the code - resolving namespace URIs of QNames once the namespace context is known - more explicit.