Implement subtyping rules for choice item types#2620
Merged
ChristianGruen merged 1 commit intoBaseXdb:mainfrom Mar 17, 2026
Merged
Implement subtyping rules for choice item types#2620ChristianGruen merged 1 commit intoBaseXdb:mainfrom
ChristianGruen merged 1 commit intoBaseXdb:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the subtyping rules for choice item types by expanding
item(),node(),gnode(), andxs:anyAtomicTypeininstanceOftests. In addition,xs:numericis handled via expansion, too, because it is not represented as a choice.As part of this change,
ChoiceItemTypehas been refactored to operate directly onTypeinstead ofSeqType. It used to be based onSeqTypemembers whenSeqTypecarried the details of node types.This fixes QT4 test cases
subtyping-027,subtyping-029,subtyping-030, andsubtyping-032.