Bump CI Flutter version to 3.47.4 - #525
Merged
Merged
Conversation
Updates the pinned Flutter version in both workflows from 3.44.4 to
3.47.4 (latest stable, ships Dart 3.13.3), and refreshes the AGENTS.md
prerequisite and the unreleased CHANGELOG bullets that quote it.
Dart 3.13 tightens `use_super_parameters`, which flagged two existing
constructors and would have failed CI's `flutter analyze` step. Both now
use super parameters; `HttpExceptionWithStatus` keeps an identical public
signature, since `HttpException` declares `const HttpException(this.message,
{this.uri})` with `String message` / `Uri? uri`. Dropping the explicit
`WebHelper?` parameter in the test helper left its `src/web/web_helper.dart`
import unused, so that import is removed too.
Package SDK floors are deliberately untouched, so the published packages
stay usable on older Flutter.
Co-Authored-By: Claude <noreply@anthropic.com>
Codifies feedback from reviewing this branch's own PR description: state facts instead of narrating the editing process, skip repeating file paths already visible in the diff, answer yes/no questions plainly (with a short breaking-change explanation only when the answer is yes), and keep testing recommendations to what a reviewer needs to act on. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
CI / maintenance — bumps the pinned Flutter version used by both packages' workflows to the current stable, plus the small source change needed to keep
flutter analyzegreen on the newer Dart.Both workflows pin Flutter 3.44.4 via a top-level
env.FLUTTER_VERSIONthat every job reads.AGENTS.mdand the[Unreleased]CHANGELOG bullets in both packages quote that same version, so they go stale whenever the pin moves.🆕 What is the new behavior (if this is a feature change)?
.github/workflows/build.yamland.github/workflows/build-firebase.yamlnow pin Flutter 3.47.4 (current stable, ships Dart 3.13.3). The version literal lives inenv:once per workflow, so no per-jobsubosito/flutter-actionblock needed touching.use_super_parameters, which flagged two existing constructors. Sinceflutter analyzeexits non-zero on info-level lints, the bump alone would have turned the quality job red, so both now use super parameters.flutter_cache_managerstays at>=3.8.0andflutter_cache_manager_firebaseat>=3.10.0. This bumps what CI tests on, not what consumers must run;flutter_cache_managersits undercached_network_image, so raising the floor deserves its own deliberate change.💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
CI's platform build jobs (Android/iOS/macOS/Windows/Linux/Web) are what actually verify this bump.
dart formatandflutter analyzepass locally on both packages;flutter testcouldn't be run locally (unrelated native-assets/Xcode issue, also present on unmodifieddevelop) — confirm thequalityjob passes on CI.📝 Links to relevant issues/docs
use_super_parameterslint🤔 Checklist before submitting
AGENTS.mdand bothCHANGELOG.mdfilesNote for reviewers: Flutter 3.47's
pub getalso wants to rewriteanalysis_options.yamlin both packages and the example, addinganalyzer: exclude:blocks forbuild/and the example's platform directories. Those rewrites were reverted here to keep this a pure version bump — CI regenerates them on every run either way, so behavior is identical. Committing them deliberately is worth a follow-up, otherwise every contributor'spub getwill dirty their working tree.🤖 Generated with Claude Code