Open
Conversation
d3e1a88 to
c8c34ff
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5367 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 5
Lines ? 115
Branches ? 0
========================================
Hits ? 115
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c8c34ff to
365b0d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the migration of client-facing internals from legacy top-level modules
(
arkouda.client,arkouda.logger,arkouda.message,arkouda.infoclass,arkouda.security)into the new
arkouda.core.*namespace.All internal imports, tests, benchmarks, documentation, and configuration have been updated
to reference
arkouda.coreas the authoritative implementation, while preserving backwardcompatibility via deprecation shims.
What changed
Core refactor & API usage
arkouda.client→arkouda.core.clientarkouda.logger→arkouda.core.loggerarkouda.message→arkouda.core.messagearkouda.infoclass→arkouda.core.infoclassarkouda.security→arkouda.core.securitygeneric_msg_no_opmaxTransferBytesto route through
arkouda.core.client.Deprecation shims
__init__.pyshims for:arkouda.core.clientarkouda.infoclassarkouda.loggerarkouda.messagearkouda.core.securityDeprecationWarningarkouda.core.*moduleTests & benchmarks
tests/core/pytest.inito include new core test paths and remove deprecated onesak.core.clientDocumentation & examples
arkouda.core.clientTooling & coverage
.coveragercand.flake8to reflect the new module layoutWhy this change
Backward compatibility
arkouda.client,arkouda.logger, etc. continue to workDeprecationWarnings guiding them toarkouda.core.*Follow-ups (out of scope)
Closes #5366: arkouda.core module