Add regression test for #337 #339
Draft
+160
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the pruning test I will be writing I would like to iterate over entire types so that I can reduce their size. This is impossible for exponentially sized types. So make them disableable in extract_final_type, and disable them for extract_value_direct (but nowhere else, since they seem to be working elsewhere). It would be nice to test that pruning works properly with massive types; it appears that it does; but that would require more work than I want to put in for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will not pass CI until we fix the bug; this adds a unit test and a fuzz test which demonstrates the issue.
Note that #338 only fixes one of the two regression tests.