Draft
Conversation
Co-authored-by: vbv <vbv@boundaryml.com>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: vbv <vbv@boundaryml.com>
Co-authored-by: vbv <vbv@boundaryml.com>
Co-authored-by: vbv <vbv@boundaryml.com>
|
🌿 Preview your docs: https://boundary-preview-55842248-6952-4f79-9106-557cac850e29.docs.buildwithfern.com |
|
🌿 Preview your docs: https://boundary-preview-e07f8a4d-99ed-41f7-91ac-8e4440107aaf.docs.buildwithfern.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Thanks for taking the time to fill out this pull request!
Issue Reference
Please link to any related issues
Changes
Please describe the changes proposed in this pull request
This PR fixes a bug where the
client_response_typeoption was incorrectly sent to the Vertex AI API, causing a 400 "Invalid JSON payload" error.Specifically:
client_response_typetoUnresolvedVertexandResolvedVertexstructs.UnresolvedVertex::create_fromto consumeclient_response_typefrom the client properties, preventing it from being included in the API request body.get_response_typemethod inVertexClientto correctly determine the response parsing strategy:client_response_type.ResponseType::Anthropicifanthropic_versionis configured.ResponseType::Vertex.chat()andstream_chat()methods inVertexClientto use this newget_response_typemethod.Testing
Please describe how you tested these changes
client_response_type: "openai"to parse responses from Vertex AI models likegpt-oss-120b-maas)Screenshots
If applicable, add screenshots to help explain your changes
[Add screenshots here...]
PR Checklist
Please ensure you've completed these items
Additional Notes
Add any other context about the PR here
This change allows users to configure
client_response_type: "openai"for Vertex AI clients, enabling BAML to correctly parse responses from models that return OpenAI-compatible formats via Vertex AI's Model Garden.Slack Thread