Add university credit line to the first-launch splash dialog - #170
Merged
Conversation
Fine-print institutional credit on the LoadingDialog shown during first-launch / MFA provisioning. The dialog's fixed height goes 260 -> 290 to fit the extra wrapped line. Split out of the app-branding work: this is presentation copy, unrelated to getting the application icon in front of end users, so it stands or falls on its own.
BeckettFrey
added a commit
that referenced
this pull request
Aug 19, 2026
The app never set an icon anywhere, so the packaged build reached users showing PyInstaller's generic executable icon and the generic Python icon in the taskbar. Three pieces are needed, because they cover different surfaces: - scripts/build.py now defaults PyInstaller's --icon to assets/vk.ico on Windows. This is the icon Explorer, the Start menu and a pinned shortcut read off the .exe itself, before the app has run at all, and it was previously an opt-in flag nobody passed. An explicit --icon still wins. - assets/ is bundled via --add-data, so the runtime lookup resolves inside a frozen build rather than only under `uv run main.py`. - QApplication.setWindowIcon and QMainWindow.setWindowIcon set the running app's taskbar and window icon; Qt needs both. get_app_icon_path prefers assets/vk.ico on Windows (multi-resolution, so it stays sharp at taskbar and title-bar sizes) and falls back to the PNG elsewhere. It resolves through get_assets_root, which handles the PyInstaller _MEIPASS case the same way get_config_root already does. The splash credit line that rode along with this originally is now #170.
Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #169, which is now icon-only.
What
Adds a fine-print institutional credit line to the
LoadingDialogshown during first launch / MFA provisioning:The dialog's fixed height goes 260 → 290 to fit the extra wrapped line.
Why it's separate
This is presentation copy. It has nothing to do with getting the application icon in front of end users, which is what #169 is about, so it stands or falls on its own — including the naming of the institutions, which is a call for whoever owns that.
Related