Repository navigation
The shared cases, replayed by a second runtime: three things PACT had wrong - #20
Merged
Merged
Conversation
… wrong Bud Agent Flow replayed tests/conformance/ and sent the cases that differed before recording any as its own. Three were PACT's. What a runtime must match A workflow's answer is held to what it says it gives. run_workflow handed back whatever the answer stage bound; it now reads each field of answers-with: by its shape and stops when one does not fit. Before anything has been remembered, a repeat's remembers: entry with no starts-as: is what its combines-by: makes of nothing: an empty list for a rule that keeps several, absent for one that keeps one. It was null. A workflow that hands back nothing answers with an empty record. An agent a workflow's stage calls is an agent's run, under its own limits, approvals and reactions (docs/99 §5). The reference workflow runtime does not run agents, and now says so. What was wrong in what PACT ships examples/language/help-centre's clear-inbox said it gives text and handed back a list. The shared case on examples/kernel/tree-search scripted ideas with no text; corrected, and the wrong data kept as a case of its own. The six routing cases move to tests/conformance/trees/routed-desk, whose agents no reaction covers, so a runtime that refuses an uncarried guard can replay them; their expect is unchanged to the letter. Owed: nothing holds an answer stage's bind: to answers-with: at check time. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #18. Bud Agent Flow replayed
tests/conformance/and sent the cases that differed before recording any as its own. Three were PACT's.What a runtime must match
run_workflowhanded back whatever theanswerstage bound; it now reads each field ofanswers-with:by its shape and stops (halted: stopped) when one does not fit.repeat'sremembers:entry with nostarts-as:is what itscombines-by:makes of nothing: an empty list for a rule that keeps several, absent for one that keeps one. It wasnullfor every rule.docs/99section 5). The reference workflow runtime does not run agents, and now says so.What was wrong in what PACT ships
examples/language/help-centre'sclear-inboxsaid it gives text and handed back a list.examples/kernel/tree-searchscripted ideas with notext. Corrected; the wrong data is kept as a case of its own that expects the run to stop.tests/conformance/trees/routed-desk; theirexpectis unchanged to the letter.Checked
scripts/test-all.shexits 0: 4872 tests (1623 Rust + 3249 adapter). The live set (10 cases ongpt-4o-mini) passes on this commit.mkdocs build --strictbuilds.newest-pydantic-aifails onmasterwith the same five failures and is not touched here.Owed
Nothing holds an
answerstage'sbind:to the workflow'sanswers-with:at check time.🤖 Generated with Claude Code