Malformed PKCS8/SPKI coverage for ML-DSA-44/65/87#243
Closed
cpu wants to merge 1 commit into
Closed
Conversation
Tests a variety of malformed PKCS8/SPKI properties for ML-DSA. Other algorithms will be considered separately using the same schema/vector generation methodology.
Member
Author
|
@davidben This might be up your alley and I'd appreciate any feedback you were able to share 🙇 |
Member
Author
|
I'll reopen this once I have a chance to extend it to other algs, and to implement the generator with the bits from #240 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a schema + vectors that test a variety of malformed PKCS8/SPKI properties for ML-DSA.
Most of the tests are not specific to ML-DSA, and indeed the schema is meant to be general enough for testing other algorithms similarly using the same vector generation methodology. I started with ML-DSA because some of these cases came up while discussing ML-DSA support in the Go standard library and we realized landing vectors here could be a more helpful contribution to the wider community. I wanted to share this work for early feedback before extending it too much further, but did attempt to write the generator code in a way that would facilitate that. Assuming I'm not way off track I will look to extend this for ECDSA, Ed25519 and RSA when time permits.
The current WIP generator code is in the
cpu-pkcs8-pkix-suite-wipbranch of my fork (notablytools/pkixkeygen/). I will likely rewrite history there as I go, but will provide a stable ref here before merging these vectors.