Open
Conversation
- not necessary, just creates noise
MilyMilo
force-pushed
the
milymilo/add-branch-to-challenges
branch
from
8a64efd to
3a7bef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we only support operating on arbitrary branches when using the
subrepomodule, however there's no reason why this should not be available forsubtreeas well.This pull replaces
get_git_repo_head_branchwith a more genericresolve_repo_urlwhich parses the repository including (optionally) a provided branch.Also fixed a deadlock logic with
ctf challenge push- essentially pushing all challenges would've never worked since we were making a commit including only the challenge path, which would always fail to push a subtree since the working directory was not clean. alternatively, committing the changes would not have pushed them, since we were looking for uncommitted changes.I don't believe pushing uncommitted changes is a right call, the cli should not implicitly just push uncommitted code. The changed implementation pushes the commits that are new, and expects changes to be committed. Also removed automatic pull since it is not required and only pollutes the git log.
fyi this can be easily tested with uv tool: