Fix sketch hull failure due to overlapping geometries.#1889
Open
huskier wants to merge 1 commit intoCadQuery:masterfrom
Open
Fix sketch hull failure due to overlapping geometries.#1889huskier wants to merge 1 commit intoCadQuery:masterfrom
huskier wants to merge 1 commit intoCadQuery:masterfrom
Conversation
Resolved a ValueError in the sketch hull algorithm that occurred when processing overlapping geometries.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1889 +/- ##
==========================================
- Coverage 95.74% 95.66% -0.08%
==========================================
Files 29 29
Lines 7583 7591 +8
Branches 1141 1144 +3
==========================================
+ Hits 7260 7262 +2
- Misses 193 196 +3
- Partials 130 133 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved a ZeroDivisionError in the sketch hull algorithm that occurred when processing overlapping geometries.
Applying the fix will allow the code below to execute as intended.