Skip to content

Replacing typish with runtype#1967

Merged
jmwright merged 6 commits intomasterfrom
runtype
Jan 16, 2026
Merged

Replacing typish with runtype#1967
jmwright merged 6 commits intomasterfrom
runtype

Conversation

@jmwright
Copy link
Member

@adam-urbanczyk As discussed in #1966 this PR attempts to replace typish with runtype. Let me know if you think there is a better replacement for get_type than get_origin.

@adam-urbanczyk
Copy link
Member

I think some massaging will be needed. I propose to add a simple instance_of wrapper in utils and use some casts in the body.

@adam-urbanczyk adam-urbanczyk mentioned this pull request Jan 15, 2026
8 tasks
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.86%. Comparing base (372ae55) to head (0e71451).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1967      +/-   ##
==========================================
+ Coverage   95.84%   95.86%   +0.01%     
==========================================
  Files          29       29              
  Lines        7951     7949       -2     
  Branches     1194     1194              
==========================================
- Hits         7621     7620       -1     
+ Misses        192      191       -1     
  Partials      138      138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmwright
Copy link
Member Author

@adam-urbanczyk Better?

@jmwright
Copy link
Member Author

Closes #1966

Copy link
Member

@adam-urbanczyk adam-urbanczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adam-urbanczyk
Copy link
Member

Thanks @jmwright , shall we merge?

@jmwright
Copy link
Member Author

Sure, I'll do that now.

@jmwright jmwright merged commit 8f91271 into master Jan 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants