Conversation
Member
|
I think some massaging will be needed. I propose to add a simple |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1967 +/- ##
==========================================
+ Coverage 95.84% 95.86% +0.01%
==========================================
Files 29 29
Lines 7951 7949 -2
Branches 1194 1194
==========================================
- Hits 7621 7620 -1
+ Misses 192 191 -1
Partials 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@adam-urbanczyk Better? |
Member
Author
|
Closes #1966 |
Member
|
Thanks @jmwright , shall we merge? |
Member
Author
|
Sure, I'll do that now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@adam-urbanczyk As discussed in #1966 this PR attempts to replace typish with runtype. Let me know if you think there is a better replacement for
get_typethanget_origin.