Load thumbnails on main screen asynchronously#1933
Open
TheLastProject wants to merge 1 commit intomainfrom
Open
Load thumbnails on main screen asynchronously#1933TheLastProject wants to merge 1 commit intomainfrom
TheLastProject wants to merge 1 commit intomainfrom
Conversation
3 tasks
TheLastProject
force-pushed
the
feature/asyncThumbnailLoading
branch
from
4b5a95b to
8338303
Compare
Decoding a bitmap can be slow. On slow devices, loading all the images as soon as the card should be shown can lead to UI freezes. By loading the thumbnail asynchronously, scrolling quickly remains smooth even on slow devices.
Member
Author
|
Hmm, this one might be controversial. It does make scrolling smoother, but you may also see the text instead of the icons for a second, even when opening the app (and this seems to also happen on relatively fast devices like Samsung Galaxy S20+ 5G). I'm not sure if it's an improvement :/ |
TheLastProject
force-pushed
the
feature/asyncThumbnailLoading
branch
from
8338303 to
0431803
Compare
Member
Author
|
Nobody ever complained about slow scrolling, so let's just keep this open in case this becomes a problem ever (so we have the fix ready) but leave it the way it is for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoding a bitmap can be slow. On slow devices, loading all the images as soon as the card should be shown can lead to UI freezes.
By loading the thumbnail asynchronously, scrolling quickly remains smooth even on slow devices.
Note: This works quite well on my Fairphone 3 with just a few images, needs testing with many images and also on fast devices.