Kotlin conversion/barcode selector activity kt conversion#2387
Draft
juuce79 wants to merge 14 commits intoCatimaLoyalty:mainfrom
Draft
Kotlin conversion/barcode selector activity kt conversion#2387juuce79 wants to merge 14 commits intoCatimaLoyalty:mainfrom
juuce79 wants to merge 14 commits intoCatimaLoyalty:mainfrom
Conversation
Have tried to keep the code as close to the original as possible while using kotlin code instead of java code.
…bout_activity_kt_conversion
- added new line at EOF. - changed if-else statement to `when` block for cleaner and more easily extensible code (lines 57-63). - now using `isVisible` extension method from the core-ktx library to make the logic more clean and simple (lines 48 & 50). - now using correct view binding pattern for activities (line 22). - removed `_binding = null` from `onDestroy()` function (line 71).
…tonVisibilityBasedOnBuildConfig` to use `isVisible` instead of checking visibility property directly with `View.VISIBLE/GONE` comparisons. This makes tests more consistent with implementation code in `AboutActivity.kt` and improves test readability.
…tlin_conversion/barcode_selector_activity_kt_conversion
Member
|
You seem to have a conflict with Your commit history seems quite messy, there are commits in there that have already been merged. Can you rebase it on top of the main branch? |
Member
Member
|
Partially superseded by #2585 (the tests weren't converted in that MR, but they are here) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conversion of
BarcodeSelectorActivityfrom java to kotlin code.BarcodeSelectorActivityTestspassbarcode_selector_activity.pdf