Conversation
bodintsov
force-pushed
the
feature/ENG-9994
branch
from
September 11, 2026 10:11
d9f9edb to
0e0b9b6
Compare
bodintsov
force-pushed
the
feature/ENG-9994
branch
from
September 11, 2026 11:18
0e0b9b6 to
6805098
Compare
cslzchen
changed the title
cslzchen
requested changes
Sep 14, 2026
cslzchen
left a comment
cslzchen
left a comment
Collaborator
There was a problem hiding this comment.
In addition, add unit tests
| view_name = 'request-resend-confirmation' | ||
| throttle_classes = (NonCookieAuthThrottle, BurstRateThrottle, RootAnonThrottle, SendEmailThrottle) | ||
|
|
||
| def get(self, request, *args, **kwargs): |
Collaborator
| view_name = 'request-resend-confirmation' | ||
| throttle_classes = (NonCookieAuthThrottle, BurstRateThrottle, RootAnonThrottle, SendEmailThrottle) | ||
|
|
||
| def get(self, request, *args, **kwargs): |
Collaborator
There was a problem hiding this comment.
In addition, take a look at the legacy view, e.g.
- Is
send_confirm_emailwhat we can use here? - There is also
user.email_last_sent = timezone.now(), is this no longer needed? - And any other pieces we need to add/update when moving legacy
flasktodjangoDRF?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Main: https://openscience.atlassian.net/browse/ENG-9994
Sub: https://openscience.atlassian.net/browse/ENG-12168
Purpose
Add an endpoint so FE can send a request to resend the confirmation URL for the email
Changes
Add an endpoint and a View so FE can send a request to resend the confirmation URL for the email
Side Effects
N/A
QE Notes
N/A
CE Notes
N/A
Documentation
N/A