Skip to content

Equipment supply water temperatures#79

Merged
t-kramer merged 7 commits intodevelopmentfrom
issue-updates-54
Mar 10, 2026
Merged

Equipment supply water temperatures#79
t-kramer merged 7 commits intodevelopmentfrom
issue-updates-54

Conversation

@urwahah
Copy link
Copy Markdown
Collaborator

@urwahah urwahah commented Mar 4, 2026

for #54:

  • revised the AWHP/WWHP performance data to consolidate each equipment model under one ID with varying supply water temperatures
  • added heating supply water temperature inputs to the equipment page
  • revised energy calculations to account for a supply temp input
  • see further inline comments in the code

next steps to complete this issue:

  • add interpolation calculation based on input supply temp
  • change supply temp inputs to be editable numbers
  • add input for performance calculation type: fixed COP, performance curves, performance coefficients
  • revise calculations to account for the above input
  • implement HHWST reset

return pd.DataFrame({"cap": cap, "cop": cop})
else:
logger.error(f"Equipment '{e.eq_id}' heating COP and capacity curves are of different lengths.")
raise ValueError(f"Equipment '{e.eq_id}' heating COP and capacity curves are of different lengths.")
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure whether the ValueError is needed if a logger error is present; i've added both but can delete if needed

},
"constraints": {
"min_temp_C": 38,
"max_temp_C": 52
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general comment for HPs: these constraints outside the supply temp data refer to the min/max supply temps for that model. this may be useful for the user input field (would probably be a couple more steps to extract the listed temps, convert to floats, and read the min/max) - but is not necessary, so can be deleted once the updates are complete

id="edit-awhp-h-supply-t-select",
label="Heating supply temperature",
placeholder="None",
data=["35", "38", "38.9", "43.3", "45", "48.9", "50", "52", "54.4", "60"], # update to be filled by callback based on currently selected HP
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for both AWHP and WWHP - this list is just all of the supply temps in the database, so during the calcs the tool will throw an error if a value that isn't listed for the current HP model is selected. the eventual goal for this input is that it's a number input, limited on both ends by the min/max temps from the database for whatever HP model is currently selected.

we will also want to be able to set this input to something that indicates HHW reset, not sure what the best way to approach that is

Output("edit-awhp-select", "data"),
Output("edit-awhp-select", "value"),
# Output("edit-awhp-h-supply-t-select", "data"), # added for autofill callback, not implemented
Output("edit-awhp-h-supply-t-select", "value"),
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i get the following error in the tool every time i open the equipment page. it doesn't seem to be affecting any functionality, but i must be missing adding the 2 new inputs somewhere

Image

@urwahah urwahah requested a review from t-kramer March 4, 2026 01:33
@t-kramer t-kramer merged commit eeb63dd into development Mar 10, 2026
@t-kramer t-kramer deleted the issue-updates-54 branch March 10, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants