Skip to content

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Feb 5, 2026

Summary of changes

This PR tries to mitigate cargo test build timeout issue.

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Centralized build flags in the CI environment to reduce overall compile times.
    • Reduced parallel build concurrency to improve stability on hosted runners.
    • Added inline comments in the workflow for clarity and future maintenance.
    • Preserved existing test-related environment variables and settings.

@hanabi1224 hanabi1224 marked this pull request as ready for review February 5, 2026 01:13
@hanabi1224 hanabi1224 requested a review from a team as a code owner February 5, 2026 01:13
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and akaladarshi and removed request for a team February 5, 2026 01:13
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

Walkthrough

Moves RUSTFLAGS to the workflow top-level env, removes per-step RUSTFLAGS, changes CARGO_BUILD_JOBS from 3 to 2 and moves it into the unit-tests run step with a hosted-runners comment, and preserves other existing env vars in .github/workflows/unit-tests.yml.

Changes

Cohort / File(s) Summary
GitHub Actions workflow
.github/workflows/unit-tests.yml
Added global RUSTFLAGS in workflow env; removed per-step RUSTFLAGS; changed CARGO_BUILD_JOBS from 3 to 2 and moved it into the unit-tests run step with a hosted-runners comment; kept other env vars unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • akaladarshi
  • sudo-shashank
  • LesnyRumcajs
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title references setting CARGO_BUILD_JOBS=2, which matches the main change in the changeset (updating CARGO_BUILD_JOBS from 3 to 2 in the CI workflow).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hm/CARGO_BUILD_JOBS-1-for-ut

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 force-pushed the hm/CARGO_BUILD_JOBS-1-for-ut branch from b94e988 to dd65538 Compare February 5, 2026 01:15
@hanabi1224 hanabi1224 force-pushed the hm/CARGO_BUILD_JOBS-1-for-ut branch from dd65538 to a4c1616 Compare February 5, 2026 01:21
@hanabi1224 hanabi1224 changed the title fix(ci): set CARGO_BUILD_JOBS=1 for unit tests fix(ci): set CARGO_BUILD_JOBS=3 for unit tests Feb 5, 2026
LesnyRumcajs
LesnyRumcajs previously approved these changes Feb 5, 2026
@hanabi1224 hanabi1224 enabled auto-merge February 5, 2026 09:37
@hanabi1224 hanabi1224 changed the title fix(ci): set CARGO_BUILD_JOBS=3 for unit tests fix(ci): set CARGO_BUILD_JOBS=2 for unit tests Feb 5, 2026
@hanabi1224 hanabi1224 added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit c277bb1 Feb 5, 2026
83 of 86 checks passed
@hanabi1224 hanabi1224 deleted the hm/CARGO_BUILD_JOBS-1-for-ut branch February 5, 2026 11:33
@hanabi1224 hanabi1224 linked an issue Feb 5, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resource exhaustion during test compilation

2 participants