Skip to content

fix(dsl): support class pointer arguments#50

Merged
nazarhussain merged 1 commit into
mainfrom
fix/dsl-class-pointer-args
Jul 14, 2026
Merged

fix(dsl): support class pointer arguments#50
nazarhussain merged 1 commit into
mainfrom
fix/dsl-class-pointer-args

Conversation

@GrapeBaBa

@GrapeBaBa GrapeBaBa commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make the class-pointer branch in convertArg comptime so *Class parameters reach unwrapChecked
  • add JS DSL integration coverage for mutating a borrowed class pointer
  • verify that passing a different wrapped class throws a TypeError before native access

Motivation

convertArg documents support for both class values and class pointers, but the pointer branch used a runtime if. Zig still analyzed the fallback @compileError, so exported functions accepting *Class could not compile. Consumers working around this with raw napi_unwrap can bypass zapi type-tag validation.

@nazarhussain nazarhussain merged commit 9dd2111 into main Jul 14, 2026
6 checks passed
@nazarhussain nazarhussain deleted the fix/dsl-class-pointer-args branch July 14, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants