Repository navigation
Conversation
Keep feedback=0 distinct from an omitted filter when listing threads. Add SQLite coverage for both feedback values, unfiltered results, owner isolation, search and cursor pagination using persisted steps and feedback. Co-Authored-By: Codex <noreply@openai.com>
imharjot
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
October 4, 2026 15:31
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Restore the original required disableFeedback column and explicitly seed its value in the feedback fixture. Keep feedback writes and thread reads on the real data-layer path. Co-Authored-By: Codex <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLAlchemyDataLayer.list_threadstreatsfeedback=0as though no feedback filter was supplied. Asking for conversations with thumbs-down feedback therefore returns positively rated and unrated conversations too.Fixes #3068
Use an explicit
Nonecheck so zero reaches the existing feedback filter. The seven SQLite regressions check negative, positive and unfiltered results, owner isolation, case-insensitive search and cursor pagination. The fixture retains the original requireddisableFeedbackcolumn and seeds compliant step rows explicitly, while users, feedback writes and thread reads use the real data-layer APIs. It also includes thepropscolumn needed by thread reads.Validation on Python 3.13.16 and Node 24.11.1:
uv sync --all-packages --all-extras --devcompleted, including the frontend build.python -m pytest --cov=chainlitusing the existing Python 3.13 environment: 939 passed after the review update. With the final fixture and the original feedback filter, the three negative-feedback cases fail and four controls pass.frontend/,pnpm test: 32 frontend tests passed.pnpm lint,pnpm format-checkandpnpm type-checkpassed. The repository's copilot type-check command explicitly reports that it is skipped.pnpm check-overridespassed.cypress/e2e/data_layer/spec.cy.tspassed, with two cases already marked pending in the repository. The first run hit a local server startup race on port 8000. The successful retry used a temporary configuration that waits for the initial server to listen and for cleanup to finish before starting the fixture; the tracked harness and test cases were unchanged.Local validation covers Python 3.13 and the persistence browser spec; the broader Python and browser matrices remain for CI.
Summary by cubic
Fixes
SQLAlchemyDataLayer.list_threadstreating afeedback=0filter as missing, so requesting thumbs-down conversations returned unrated and positively rated ones too.filters.feedback is not Noneso a zero value reaches the existing feedback filter.Written for commit 272129a. Summary will update on new commits.