Skip to content

hp_proliant_da_cntlr: do not discover phantom controllers #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bastian-Kuhn wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

hp_proliant_da_cntlr: do not discover phantom controllers #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cmk/plugins/hp_proliant/agent_based/hp_proliant_da_cntlr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,9 @@ def parse_hp_proliant_da_cntlr(string_table: StringTable) -> ParsedSection:


def discovery_hp_proliant_da_cntlr(section: ParsedSection) -> DiscoveryResult:
if section:
yield from (Service(item=item) for item in section)
# Skip phantom placeholder rows (all-zero cells, parsed to ``None``): they
# are not real controllers and would produce a permanently UNKNOWN service.
yield from (Service(item=item) for item, data in section.items() if data is not None)


def check_hp_proliant_da_cntlr(item: ControllerID, section: ParsedSection) -> CheckResult:
Expand Down
1 change: 0 additions & 1 deletion tests/unit/cmk/plugins/hp_proliant/agent_based/test_hp_proliant_da_cntlr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def test_discovery() -> None:
Service(item="0"),
Service(item="3"),
Service(item="6"),
Service(item="9"),
]


Expand Down
Loading