Repository navigation
test: migrate PWA browser-scoped handler test to mocks - #2756
Merged
Lightning00Blade merged 2 commits intoSep 30, 2026
Merged
Lightning00Blade merged 2 commits into
Lightning00Blade merged 2 commits into
Conversation
lisa0314
force-pushed
the
test/2639-pwa-browser-scope-mocks
branch
from
September 29, 2026 02:48
0d7fe62 to
9a74196
Compare
Lightning00Blade
approved these changes
Sep 30, 2026
Lightning00Blade
approved these changes
Sep 30, 2026
Lightning00Blade
enabled auto-merge
September 30, 2026 10:07
Merged
via the queue into
ChromeDevTools:main
with commit Sep 30, 2026
d80882c
28 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2639.
Summary
createHandlerMocks()andcreateMockPuppeteerPage(). It previously launched Chrome even though all four PWA operations were already stubbed.No production code or shared mock helpers are changed.
Testing
npm run check-format: passed;git diff --check: passed.8939965, using Chrome 152.0.7977.83 on macOS with Node 24.18.0.PUPPETEER_EXECUTABLE_PATH=/nonexistent/pwa-unit-tests/chrome, the migrated test passes; the original test on the same main fails because it tries to launch Chrome.npm run teston both this change and a clean same-main worktree: 1056 passed, 4 failed, 3 skipped each. Both fail the previous-navigation network snapshot and oversized screenshot tests. Both also have extension-related failures, but the failing extension lifecycle/content-script case differs. A focused rerun of all three extension cases implicated across the two runs passes 3/3 on both worktrees. These are not green full-suite runs.Rebase verification (2026-09-29)
47c5b37preserves a single test-only commit intests/tools/pwa.test.ts.PUPPETEER_EXECUTABLE_PATH=/Applications/Google Chrome.app/Contents/MacOS/Google Chrome npm run test tests/tools/pwa.test.ts: 6/6 passed;npm run check-formatandgit diff --check: passed.47c5b37.