Enable KEEPALIVE server side#111
Closed
Protonull wants to merge 1 commit intoCivPlatform:mainfrom
Protonull:tcp-keepalive
Closed
Enable KEEPALIVE server side#111Protonull wants to merge 1 commit intoCivPlatform:mainfrom Protonull:tcp-keepalive
Protonull wants to merge 1 commit intoCivPlatform:mainfrom
Protonull:tcp-keepalive
Conversation
This is already enabled clientside, but [presumably] has no effect because the server does not have it enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SO_KEEPALIVEis already enabled clientside, which I presume means the client can detect unexpected disconnects, but not the server? Enabling it for the server too should resolve #7, but I'm unsure: why would websockets for example need ping/pong packets if tcp's keepalive already does that?