-
Notifications
You must be signed in to change notification settings - Fork 35
Reference Clickhouse credentials in secret #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nam Hai Nguyen <[email protected]>
Signed-off-by: Nam Hai Nguyen <[email protected]>
|
Could we also please add the clickhouse user's password to be referenced from a secret |
I think this is a different use case |
dhable
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. There's a merge conflict, probably around the version, that needs to be resolved. If you revert the Chart.yaml change, it should allow merging in main into your PR branch.
We also would like a changeset in the PR as well. You can create this by running yarn install from the root to install the changeset CLI. Then run yarn changeset and follow the prompts to generate the required files. We can't generate a release without that.
Signed-off-by: Nam Hai Nguyen <[email protected]>
🦋 Changeset detectedLatest commit: 0183a3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Nam Hai Nguyen <[email protected]>
Use
secretKeyRefto not expose Clickhouse credentials into runtime environment