Refactor: libcrmcommon: New append_xml_escaped_fn_t - #4160
Open
nrwahl2 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
nrwahl2
force-pushed
the
nrwahl2-acls_demo
branch
from
August 8, 2026 08:09
c6599ed to
d70ade5
Compare
nrwahl2
commented
Aug 8, 2026
| append_xml_escaped_fn_t append_char_fn = NULL; | ||
| GString *copy = NULL; | ||
|
|
||
| pcmk__assert((type >= 0) && (type <= pcmk__xml_escape_attr_pretty)); |
Contributor
Author
There was a problem hiding this comment.
I'm already on the fence about merging this -- clarity and brevity are about the same before and after. And here, for this bounds check, we assume that pcmk__xml_escape_attr_pretty is the maximum enum value. That's true right now and probably will be forever. But semantically there's no reason pcmk__xml_escape_attr_pretty should be greater than pcmk__xml_escape_text or pcmk__xml_escape_attr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.