Skip to content

189 Dev Aaron - Delete Notification Backend Route - #209

Merged
prooflesben merged 1 commit into
mainfrom
aaron/delete-notification-route
Nov 10, 2025
Merged

prooflesben merged 1 commit into
mainfrom
aaron/delete-notification-route

Conversation

@aaronashby

Copy link
Copy Markdown
Contributor

ℹ️ Issue

Closes #189

📝 Description

I created a backend route to delete a notification with a given ID from the notifications table.

Changes made to the code:

  1. Created deleteNotification() method innotification.controller.ts, which can be accessed via the URL, notifications/:notificationId that delegates to the corresponding method in notification.service.ts
  2. Added deleteNotification() method in service that takes in the notificationId from the controller, and deletes the notification with that id from the database
  3. Created unit tests to test a successful deletion and failures to delete in the following cases
  • If the environment variable for the notifications table name is not set
  • If the notification with the given id does not exist

✔️ Verification

I added tests for the above cases
Screenshot 2025-11-05 at 11 49 32 PM

🏕️ (Optional) Future Work / Notes

None

@prooflesben prooflesben left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff future tech lead

@prooflesben
prooflesben merged commit 4f35646 into main Nov 10, 2025
1 check passed
@janekamata
janekamata deleted the aaron/delete-notification-route branch April 17, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEV- delete notification backend route

2 participants