Repository navigation
189 Dev Aaron - Delete Notification Backend Route - #209
Merged
Merged
Conversation
prooflesben
approved these changes
Nov 10, 2025
prooflesben
left a comment
Collaborator
There was a problem hiding this comment.
Good stuff future tech lead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #189
📝 Description
I created a backend route to delete a notification with a given ID from the notifications table.
Changes made to the code:
deleteNotification()method innotification.controller.ts, which can be accessed via the URL,notifications/:notificationIdthat delegates to the corresponding method innotification.service.tsdeleteNotification()method in service that takes in the notificationId from the controller, and deletes the notification with that id from the database✔️ Verification
I added tests for the above cases

🏕️ (Optional) Future Work / Notes
None