Repository navigation
date validation - #415
Merged
Merged
date validation#415
Conversation
6 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the frontend grant editing flow to enforce basic date ordering constraints, and simplifies the login UI by removing the “Remember Me” / “Forgot Password” section.
Changes:
- Added validation to prevent
applicationDatebeing after the due date andgrantStartDatebeing before the due date in the Edit Grant form. - Removed “Remember Me” checkbox state and the “Forgot Password?” UI block from the login page.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| frontend/src/main-page/grants/edit-grant/EditGrant.tsx | Adds client-side date ordering checks in validateInputs() for application/due/start dates. |
| frontend/src/login/Login.tsx | Removes “Remember Me” state and the “Remember Me / Forgot Password” UI section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4 tasks
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… the inactive user, and that clickingback to login would log the user out (changed that to navigating to login instead) so the user stays logged in on the other tab and can refresh to refetch data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes
📝 Description
Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.
Briefly list the changes made to the code:
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Provide screenshots of any new components, styling changes, or pages.
Test Changes
If your new feature required some test to be changed or added to fit the new functionality or changes please document these changes here.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!