London | 25-ITP-May | Houssam Lahlah | Sprint 3 | Programmer humour#319
Closed
HoussamLh wants to merge 4 commits intoCodeYourFuture:mainfrom
Closed
London | 25-ITP-May | Houssam Lahlah | Sprint 3 | Programmer humour#319HoussamLh wants to merge 4 commits intoCodeYourFuture:mainfrom
HoussamLh wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
- implement getLatestComic function to fetch latest comic from API - display comic image in DOM and log JSON data add error handling for failed API requests
- implement getLatestComic function to fetch latest comic from API - display comic image in DOM and log JSON data - add error handling for failed API requests
A-O-Emmanuel
left a comment
There was a problem hiding this comment.
Your approach works and meets up with the task requirements, however, for real world scenarios, consider adding a loading indicator before displaying the data, that is, before displaying the image in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Title:
Add Programmer Humour XKCD Comic Project
Description:
This PR adds a small project that fetches and displays the latest XKCD comic using the API https://xkcd.now.sh/?comic=latest.
Features:
Questions