Birmingham | ITP-Jan | Roman Sanaye | Sprint 2 | Exercises

[RomanSanaye]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

• Completed all exercises in this sprint, including the following folders:
  • Debugging: fixed errors and improved code logic.
  • Implement: implemented required functions and features as instructed.
  • Interpret: interpreted given code snippets and exercises.
  • Stretch: completed advanced challenges, including the totalTill function.
• Added Jest tests for key functions where required, including the totalTill function.
• Ensured all functions are beginner-friendly, tested, and formatted according to the style guide.

Questions

No questions at this time.

[cjyuan]

output and pair are not going to be reassigned a value, so a better practice is to declare them using const.

We can still modify the array or object assigned to a constant in JS, we just cannot reassign another value to the constant.

[RomanSanaye]

let was replaced with const, and it is a safer option.

[cjyuan]

Other changes look good.

[cjyuan]

In practice, we prepare tests not just to check our own implementation, but also to guard against future modification.

Currently, this incorrectly implemented function could also pass this test:

function contains(object, key) {
  if (object === null || typeof object !== "object") {
    return false;
  }
  return Object.prototype.hasOwnProperty.call(object, key);
}