Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 2 | Data Groups by Pretty548 · Pull Request #1109 · CodeYourFuture/Module-Data-Groups

Pretty548 · 2026-03-26T21:19:39Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Fixed parseQueryString implementation and handled edge cases
Fixed contains function bug
Implemented tally function with validation
Fixed calculateMedian to handle invalid inputs

2. correct import path for createLookup in tests 3.add jest and configure test script.

…roups into sprint-2

cjyuan · 2026-03-28T14:08:50Z

Sprint-2/implement/contains.js

@@ -1,3 +1,7 @@
-function contains() {}
+function contains(obj, key) {
+  if (!obj) return false;


Supposedly, when obj is one of the following types of value, the function should return false.

[1,2,3], 123, true, "string"

Good catch! I updated the function to ensure it only accepts plain objects by checking for non-object types, null, and arrays. It now correctly returns false for values like arrays, numbers, Booleans, and strings.

cjyuan · 2026-03-28T14:13:42Z

Sprint-2/implement/contains.js

+function contains(obj, key) {
+  if (!obj) return false;
+
+  return Object.prototype.hasOwnProperty.call(obj, key);


Can also consider Object.hasOwn().

Thanks! I updated the implementation to use Object.hasOwn() and ensured the function returns false for non-object inputs instead of throwing an error.

cjyuan · 2026-03-28T14:14:34Z

Sprint-2/implement/contains.test.js

+test("returns false for an array", () => {
+  expect(contains([], "a")).toBe(false);
+});
+


This test does not yet confirm that the function correctly returns false when the first argument is an array.
This is because contains([], "a") could also return false simply because "a" is not a key of the array.

Arrays are objects, with their indices acting as keys. A proper test should use a non-empty array along with a valid
key to ensure the function returns false specifically because the input is an array, not because the key is missing.

Good point! I’ve updated the test to use a non-empty array with a valid index as the key, so it confirms the function returns false specifically because the input is an array.

cjyuan · 2026-03-28T14:16:16Z

Sprint-2/implement/querystring.js

+  pairs.forEach((pair) => {
+    if (!pair) return;
+
+    const index = pair.indexOf("=");
+
+    if (index === -1) {
+      result[pair] = "";
+    } else {
+      const key = pair.slice(0, index);
+      const value = pair.slice(index + 1);
+      result[key] = value;
+    }
+  });


For the following function call, does your function return the value you expect?

parseQueryString("key1=value1&&key2=value2")

Yes, the function correctly handles this case. The double "&&" creates an empty string when splitting, and the check if (!pair) return; ensures it is ignored. The function returns the expected result with both key-value pairs.

cjyuan · 2026-03-28T14:16:41Z

Sprint-2/implement/tally.js

+  const result = {};
+
+  items.forEach((item) => {
+    if (result[item]) {
+      result[item]++;
+    } else {
+      result[item] = 1;
+    }
+  });


Does the following function call returns the value you expect?

tally(["toString", "toString"]);

Suggestion: Look up an approach to create an empty object with no inherited properties.

Good catch! I updated the implementation to use Object.create(null) so the result object has no inherited properties. This ensures keys like "toString" are handled correctly.

cjyuan · 2026-03-28T14:18:11Z

Sprint-2/interpret/invert.js

+const invert = require("./invert");
+
+test("inverts a simple object", () => {
+  expect(invert({ a: 1 })).toEqual({ 1: "a" });
+});
+
+test("inverts an object with multiple key-value pairs", () => {
+  expect(invert({ a: 1, b: 2 })).toEqual({
+    1: "a",
+    2: "b",
+  });
+});
+
+test("returns empty object when given an empty object", () => {
+  expect(invert({})).toEqual({});
+});
+
+test("handles non-string values as keys in the inverted object", () => {
+  expect(invert({ a: 1, b: true, c: null })).toEqual({
+    1: "a",
+    true: "b",
+    null: "c",
+  });
+});


Shouldn't this be implemented in invert.test.js?

Good catch, thanks! You're right — these tests should live in invert.test.js. I'll move them there to keep the test structure consistent and separated from implementation.

…om>Move invert tests from invert.js to invert.test.js

Pretty Taruvinga added 14 commits March 7, 2026 14:25

implement correct median calculation

53fa90f

Access houseNumber correctly from address object

7b40348

Use Object.values to loop through author object

c04e2dc

display ingredients correctly instead of object

59fff2a

Add contains function to check if value exists in array

bbdc491

implement contains function for object property check

904055c

implement contains test cases

7f28769

Made it look clean

e6ec9d4

Implement createLookup function for country-currency pairs

067f3e1

set up jest and add test script

5b88737

1. add createLookup test cases for multiple and empty inputs

92c0f04

2. correct import path for createLookup in tests 3.add jest and configure test script.

Correctly parse query strings with '=' in values and edge cases"

12f79f0

Implement tally function with error handling and tests"

3c7d554

Correctly invert object keys and values using bracket notation"

78d5e44

This comment has been minimized.

Sign in to view

Pretty548 changed the title ~~Sprint 2~~ Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 2 | Data Groups Mar 26, 2026

This comment has been minimized.

Sign in to view

Pretty Taruvinga and others added 2 commits March 27, 2026 13:29

Revert to main

4c3daf6

Merge branch 'main' into sprint-2

db6200c

Pretty548 marked this pull request as draft March 27, 2026 11:32

Pretty548 marked this pull request as ready for review March 27, 2026 11:32

Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026

Merge branch 'sprint-2' of https://github.com/Pretty548/Module-Data-G…

c3b7bf0

…roups into sprint-2

Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026

removed the package.json

1b5a7e8

Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026

cjyuan reviewed Mar 28, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 28, 2026

Pretty Taruvinga added 7 commits March 28, 2026 19:35

Fix contains to return false for non-object inputs

1f43925

Use Object.hasOwn and handle non-object inputs correctly

84d5a4e

Improve array test to ensure contains returns false for valid array keys

b996f9f

Handle empty query string pairs correctly

92779c2

Add invert.test.js and move tests from invert.js

c864665

Separate invert tests from implementation into invert.test.js

c547fdc

Co-authored-by: Isaac Abodunrin <bytesandroses@users.noreply.github.c…

cdfdd7c

…om>Move invert tests from invert.js to invert.test.js

Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 28, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 28, 2026

deleted an unnecessary file

7846797

Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 28, 2026

Uh oh!

Conversation

Pretty548 commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Pretty548 commented Mar 26, 2026 •

edited

Loading