Feature/8726 portal deprecated remove

[bdalsass]

Base information

Question	Answer
Related to a SourceForge thread / Another PR / A GitHub Issue / Combodo ticket?	https://support.combodo.com/pages/UI.php?operation=details&class=Bug&id=8726
Type of change?	Bug fix

Symptom (bug) / Objective (enhancement)

Remove portal deprecated API

Checklist before requesting a review

• I have performed a self-review of my code
• I have tested all changes I made on an iTop instance
• I have added a unit test, otherwise I have explained why I couldn't
• Is the PR clear and detailed enough so anyone can understand without digging in the code?

[Copilot]

Pull request overview

Removes obsolete portal compatibility APIs as part of bug #8726.

Changes:

• Removes deprecated URL and modal helpers.
• Removes legacy form callback fields.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
layout.html.twig	Removes AddParameterToUrl.
ObjectFormHandlerHelper.php	Removes legacy callback data.
toolbox.js	Removes deprecated modal wrappers.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[greptile-apps]

Greptile Summary

This PR removes deprecated portal compatibility APIs after their first-party consumers migrated to supported replacements.

• Removes deprecated CombodoPortalToolbox modal wrappers.
• Removes obsolete submit_callback and cancel_callback form-data aliases.
• Removes the deprecated global AddParameterToUrl helper.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete first-party regression identified.

All removed APIs were previously deprecated, repository callers use the retained replacements, and the active form and template paths do not consume the removed compatibility fields or globals.

Important Files Changed

Filename	Overview
datamodels/2.x/itop-portal-base/portal/public/js/toolbox.js	Removes deprecated modal wrappers; repository callers already use the supported CombodoModal API.
datamodels/2.x/itop-portal-base/portal/src/Helper/ObjectFormHandlerHelper.php	Removes unused callback aliases while retaining the navigation-rule fields consumed by the portal form widget.
datamodels/2.x/itop-portal-base/portal/templates/layout.html.twig	Removes a deprecated global URL helper after repository callers migrated to CombodoGlobalToolbox.AddParameterToUrl.

_{Reviews (1): Last reviewed commit: "N°8726 - Deprecation cleanup in portal" | Re-trigger Greptile}

[Molkobain]

Some modules still to be migrated, otherwise core modifications look good.

[Molkobain]

There is still a usage of this in combodo-custom-hyperlinks

[Molkobain]

There are still usages of this in approval-base and combodo-workflow-graphical-view.
Careful about the default value fallback during migration of these modules.