N°9643 - Dataflow: split protocol & type, add url and last change

[v-dumas]

Base information

Question	Answer
Related to a Combodo ticket?	N°9643
Type of change?	Enhancement

Objective (enhancement)

Implement feedback from partner

Proposed solution (bug and enhancement)

Checklist before requesting a review

• I have performed a self-review of my code
• I have tested all changes I made on an iTop instance
• I have added a unit test, otherwise I have explained why I couldn't
• Is the PR clear and detailed enough so anyone can understand without digging in the code?

[greptile-apps]

Greptile Summary

This enhancement separates data-flow protocols from data-flow types and adds documentation URL and last-change-date metadata.

• Adds the DataFlowProtocol typology, dashboard badge, foreign key, and protocol seed values.
• Replaces the original type seed values with REST API, Kafka, JSON, XML, and CSV.
• Adds localized labels and exposes the new fields in DataFlow details.

Confidence Score: 3/5

The PR should not be merged until upgrades populate and migrate the new protocol typology and the broken French last-change-date dictionary keys are corrected.

Existing installations do not receive the new protocol seed records or migrated protocol values through the declared structural-data path, and French users cannot resolve the new date field's localized label.

Files Needing Attention: datamodels/2.x/itop-flow-map/module.itop-flow-map.php, datamodels/2.x/itop-flow-map/dictionaries/fr.dict.itop-flow-map.php

Important Files Changed

Filename	Overview
datamodels/2.x/itop-flow-map/module.itop-flow-map.php	Registers the replacement and new structural datasets, but provides no upgrade path to insert protocols or migrate existing classifications.
datamodels/2.x/itop-flow-map/datamodel.itop-flow-map.xml	Adds the protocol relationship, URL/date fields, protocol typology, presentations, and dashboard badge using established model patterns.
datamodels/2.x/itop-flow-map/data/data.itop-dataflowprotocol.xml	Defines seven protocol records that work for fresh installations but are not populated by the existing-module upgrade path.
datamodels/2.x/itop-flow-map/data/data.itop-dataflowtype.xml	Replaces protocol-like DataFlowType seed values with format/technology values without migrating existing records.
datamodels/2.x/itop-flow-map/dictionaries/fr.dict.itop-flow-map.php	Adds French labels, but the last-change-date label and description use keys that do not match the field identifier.

Entity Relationship Diagram

%%{init: {'theme': 'neutral'}}%%
erDiagram
  DataFlowType ||--o{ DataFlow : "classifies type"
  DataFlowProtocol ||--o{ DataFlow : "classifies protocol"
  DataFlow {
    int dataflowtype_id
    int dataflowprotocol_id
    string documentation_url
    date last_change_date
  }
  DataFlowType {
    int id
    string name
  }
  DataFlowProtocol {
    int id
    string name
  }

Loading

_{Reviews (1): Last reviewed commit: "N°9643 - Dataflow: split protocol & type..." | Re-trigger Greptile}

[Copilot]

Pull request overview

Adds separate data-flow type and protocol typologies, plus documentation URL and last-change metadata.

Changes:

• Adds protocol, URL, and last-change fields.
• Splits default type and protocol data.
• Updates five translations.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
module.itop-flow-map.php	Registers typology data files.
datamodel.itop-flow-map.xml	Extends the data model and UI.
data.itop-dataflowtype.xml	Updates default flow types.
data.itop-dataflowprotocol.xml	Adds default protocols.
en.dict.itop-flow-map.php	Adds English labels.
fr.dict.itop-flow-map.php	Adds French labels.
nl.dict.itop-flow-map.php	Adds Dutch labels.
ru.dict.itop-flow-map.php	Adds Russian labels.
zh_cn.dict.itop-flow-map.php	Adds Chinese labels.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.