Skip to content

fix: continue rendering when 3D animation is playing#7836

Merged
jtydhr88 merged 1 commit intomainfrom
fix/3d-animation-continue-rendering
Jan 5, 2026
Merged

fix: continue rendering when 3D animation is playing#7836
jtydhr88 merged 1 commit intomainfrom
fix/3d-animation-continue-rendering

Conversation

@jtydhr88
Copy link
Copy Markdown
Collaborator

@jtydhr88 jtydhr88 commented Jan 4, 2026

Summary

Previously, the 3D viewer would pause rendering when the mouse left the node to save resources. This caused GLB/FBX animations to freeze when the user moved the mouse away, which was a poor user experience.

Now the renderer stays active while an animation is playing, and only pauses when the animation is stopped.

fix #7827

┆Issue is synchronized with this Notion page by Unito

@jtydhr88 jtydhr88 requested a review from a team as a code owner January 4, 2026 01:05
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 4, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 4, 2026

📝 Walkthrough

Walkthrough

The isActive() method in Load3d.ts has been modified to consider animation playback as an active state. The condition now checks both the initial render state and whether an animation is currently playing, ensuring the component remains active during animation playback.

Changes

Cohort / File(s) Summary
Animation Playback State Logic
src/extensions/core/load3d/Load3d.ts
Modified isActive() method to check this.animationManager.isAnimationPlaying in addition to !INITIAL_RENDER_DONE, allowing the component to remain active while an animation is playing.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR addresses the core requirement from issue #7827 by modifying isActive() to keep rendering active during animation playback, directly solving the animation interruption problem.
Out of Scope Changes check ✅ Passed All changes are scoped to the animation playback rendering behavior; no unrelated modifications or scope creep detected.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d1f8ed and f292e33.

📒 Files selected for processing (1)
  • src/extensions/core/load3d/Load3d.ts
🧰 Additional context used
📓 Path-based instructions (7)
src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

  • src/extensions/core/load3d/Load3d.ts
src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

Files:

  • src/extensions/core/load3d/Load3d.ts
src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

Files:

  • src/extensions/core/load3d/Load3d.ts
src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

  • src/extensions/core/load3d/Load3d.ts
**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,vue}: Use TypeScript exclusively; do not write new JavaScript code
Use sorted and grouped imports organized by plugin/source
Enforce ESLint rules including Vue + TypeScript rules, disallow floating promises, disallow unused imports, and restrict i18n raw text in templates
Do not use any type or as any type assertions; fix the underlying type issue instead
Write code that is expressive and self-documenting; avoid redundant comments and clean as you go
Keep functions short and functional; minimize nesting and follow the arrow anti-pattern
Avoid mutable state; prefer immutability and assignment at point of declaration
Use function declarations instead of function expressions when possible
Use es-toolkit for utility functions
Implement proper error handling in code

Files:

  • src/extensions/core/load3d/Load3d.ts
**/*.{ts,tsx,vue,js,jsx,json,css}

📄 CodeRabbit inference engine (AGENTS.md)

Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, and 80-character line width

Files:

  • src/extensions/core/load3d/Load3d.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Minimize the surface area (exported values) of each module and composable

Files:

  • src/extensions/core/load3d/Load3d.ts
🧠 Learnings (5)
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

  • src/extensions/core/load3d/Load3d.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

  • src/extensions/core/load3d/Load3d.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

  • src/extensions/core/load3d/Load3d.ts
📚 Learning: 2025-12-30T22:22:33.836Z
Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().

Applied to files:

  • src/extensions/core/load3d/Load3d.ts
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

  • src/extensions/core/load3d/Load3d.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: test
  • GitHub Check: setup
  • GitHub Check: lint-and-format
  • GitHub Check: collect
🔇 Additional comments (1)
src/extensions/core/load3d/Load3d.ts (1)

395-396: The logic change is correct and properly keeps rendering active during animation playback.

The code correctly accesses isAnimationPlaying as a boolean property (not a method) in the AnimationManager class, defined at line 14 of AnimationManager.ts. The added condition at line 396 properly aligns with the PR objectives by preventing rendering interruption while animations play.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 4, 2026

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 01/04/2026, 01:12:28 AM UTC

📈 Summary

  • Total Tests: 511
  • Passed: 500 ✅
  • Failed: 0
  • Flaky: 3 ⚠️
  • Skipped: 8 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 490 / ❌ 0 / ⚠️ 2 / ⏭️ 8
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 4, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/04/2026, 01:07:20 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 4, 2026

Bundle Size Report

Summary

  • Raw size: 17.3 MB baseline 17.3 MB — 🔴 +44 B
  • Gzip: 3.54 MB baseline 3.54 MB — 🟢 -48 B
  • Brotli: 2.7 MB baseline 2.7 MB — 🔴 +147 B
  • Bundles: 98 current • 98 baseline • 43 added / 43 removed

Category Glance
App Entry Points 🔴 +44 B (3.21 MB) · Vendor & Third-Party ⚪ 0 B (9.12 MB) · Other ⚪ 0 B (3.47 MB) · Graph Workspace ⚪ 0 B (1000 kB) · Panels & Settings ⚪ 0 B (300 kB) · UI Components ⚪ 0 B (199 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.21 MB (baseline 3.21 MB) • 🔴 +44 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-CaVfeJG6.js (new) 3.02 MB 🔴 +3.02 MB 🔴 +634 kB 🔴 +482 kB
assets/index-BA5eZMZ8.js (removed) 3.02 MB 🟢 -3.02 MB 🟢 -634 kB 🟢 -482 kB
assets/index-BeQcOYVA.js (new) 194 kB 🔴 +194 kB 🔴 +42.3 kB 🔴 +35.1 kB
assets/index-CRAS7mlZ.js (removed) 194 kB 🟢 -194 kB 🟢 -42.3 kB 🟢 -35.1 kB
assets/index-D3IN9jtD.js (new) 345 B 🔴 +345 B 🔴 +246 B 🔴 +235 B
assets/index-Dliiq7GE.js (removed) 345 B 🟢 -345 B 🟢 -246 B 🟢 -202 B

Status: 3 added / 3 removed

Graph Workspace — 1000 kB (baseline 1000 kB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-_2hyjqIs.js (new) 1000 kB 🔴 +1000 kB 🔴 +194 kB 🔴 +148 kB
assets/GraphView-RZbHHAs9.js (removed) 1000 kB 🟢 -1000 kB 🟢 -194 kB 🟢 -148 kB

Status: 1 added / 1 removed

Views & Navigation — 6.63 kB (baseline 6.63 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-Bfhyz6CQ.js (removed) 6.63 kB 🟢 -6.63 kB 🟢 -2.15 kB 🟢 -1.9 kB
assets/UserSelectView-D_TiiEE8.js (new) 6.63 kB 🔴 +6.63 kB 🔴 +2.15 kB 🔴 +1.9 kB

Status: 1 added / 1 removed

Panels & Settings — 300 kB (baseline 300 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/LegacyCreditsPanel-BSc8qQti.js (new) 22.7 kB 🔴 +22.7 kB 🔴 +5.26 kB 🔴 +4.6 kB
assets/LegacyCreditsPanel-BTj4WiCP.js (removed) 22.7 kB 🟢 -22.7 kB 🟢 -5.26 kB 🟢 -4.6 kB
assets/KeybindingPanel-DAvzJxkS.js (removed) 14.8 kB 🟢 -14.8 kB 🟢 -3.58 kB 🟢 -3.12 kB
assets/KeybindingPanel-wGbxKUfF.js (new) 14.8 kB 🔴 +14.8 kB 🔴 +3.58 kB 🔴 +3.12 kB
assets/ExtensionPanel-BY0XlxQJ.js (removed) 11.1 kB 🟢 -11.1 kB 🟢 -2.62 kB 🟢 -2.3 kB
assets/ExtensionPanel-DiEJYgiK.js (new) 11.1 kB 🔴 +11.1 kB 🔴 +2.62 kB 🔴 +2.3 kB
assets/AboutPanel-B3i-r3u8.js (removed) 9.16 kB 🟢 -9.16 kB 🟢 -2.46 kB 🟢 -2.21 kB
assets/AboutPanel-w75JbA4m.js (new) 9.16 kB 🔴 +9.16 kB 🔴 +2.46 kB 🔴 +2.21 kB
assets/ServerConfigPanel-Be-EjBOO.js (new) 7.51 kB 🔴 +7.51 kB 🔴 +2.04 kB 🔴 +1.81 kB
assets/ServerConfigPanel-Dk6UqSeW.js (removed) 7.51 kB 🟢 -7.51 kB 🟢 -2.05 kB 🟢 -1.81 kB
assets/UserPanel-DgwA3ZvX.js (new) 6.88 kB 🔴 +6.88 kB 🔴 +1.79 kB 🔴 +1.57 kB
assets/UserPanel-kN7QRKuQ.js (removed) 6.88 kB 🟢 -6.88 kB 🟢 -1.79 kB 🟢 -1.57 kB
assets/settings-AN2JfZVQ.js 21.7 kB 21.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BhbWhsRg.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BIdKi-OT.js 26.2 kB 26.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-Bu3OR-lX.js 24.6 kB 24.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-ByL6gy5c.js 25.4 kB 25.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CjlRFMdL.js 32.8 kB 32.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DkGwvylK.js 26.9 kB 26.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-Dyd027Dx.js 24.7 kB 24.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-wwBxqLH5.js 21.3 kB 21.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-xx2Yb6R2.js 23.8 kB 23.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

UI Components — 199 kB (baseline 199 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/LazyImage.vue_vue_type_script_setup_true_lang-DRcyJosZ.js (new) 60.1 kB 🔴 +60.1 kB 🔴 +12.4 kB 🔴 +10.8 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-HPBE6lG2.js (removed) 60.1 kB 🟢 -60.1 kB 🟢 -12.4 kB 🟢 -10.8 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-D1Qtit1E.js (removed) 56.4 kB 🟢 -56.4 kB 🟢 -8.91 kB 🟢 -7.61 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-DJnqj180.js (new) 56.4 kB 🔴 +56.4 kB 🔴 +8.91 kB 🔴 +7.62 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-B1saCDXG.js (new) 49 kB 🔴 +49 kB 🔴 +10.5 kB 🔴 +9.14 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-E_T68qC-.js (removed) 49 kB 🟢 -49 kB 🟢 -10.5 kB 🟢 -9.14 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-D4U_-jer.js (new) 14.6 kB 🔴 +14.6 kB 🔴 +3.79 kB 🔴 +3.33 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-DwCrWJcs.js (removed) 14.6 kB 🟢 -14.6 kB 🟢 -3.79 kB 🟢 -3.34 kB
assets/ComfyQueueButton-BBmbkg14.js (removed) 8.83 kB 🟢 -8.83 kB 🟢 -2.58 kB 🟢 -2.3 kB
assets/ComfyQueueButton-BJOm5vMe.js (new) 8.83 kB 🔴 +8.83 kB 🔴 +2.58 kB 🔴 +2.29 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-D2EI-2lh.js (new) 3.72 kB 🔴 +3.72 kB 🔴 +1.46 kB 🔴 +1.32 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-vn4lpTWx.js (removed) 3.72 kB 🟢 -3.72 kB 🟢 -1.46 kB 🟢 -1.32 kB
assets/WidgetButton-Cb_pxbvX.js (new) 2.21 kB 🔴 +2.21 kB 🔴 +998 B 🔴 +872 B
assets/WidgetButton-vx-B0FJ7.js (removed) 2.21 kB 🟢 -2.21 kB 🟢 -998 B 🟢 -898 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-Dsd391Lz.js (removed) 2.14 kB 🟢 -2.14 kB 🟢 -892 B 🟢 -771 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-MEs1q_fS.js (new) 2.14 kB 🔴 +2.14 kB 🔴 +890 B 🔴 +764 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-C-HCcuVC.js (new) 897 B 🔴 +897 B 🔴 +501 B 🔴 +444 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-CIXHQiQ6.js (removed) 897 B 🟢 -897 B 🟢 -505 B 🟢 -446 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-DV-9JnFV.js 1.34 kB 1.34 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 9 added / 9 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-CeBqhuI0.js (removed) 7.51 kB 🟢 -7.51 kB 🟢 -1.83 kB 🟢 -1.58 kB
assets/keybindingService-CGrIoz6k.js (new) 7.51 kB 🔴 +7.51 kB 🔴 +1.83 kB 🔴 +1.59 kB
assets/audioService-B9HRmp4S.js (new) 2.2 kB 🔴 +2.2 kB 🔴 +963 B 🔴 +831 B
assets/audioService-BlUatW80.js (removed) 2.2 kB 🟢 -2.2 kB 🟢 -961 B 🟢 -826 B
assets/serverConfigStore-CulKZi3K.js 2.83 kB 2.83 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/audioUtils-6lEzZnsy.js (removed) 1.41 kB 🟢 -1.41 kB 🟢 -652 B 🟢 -548 B
assets/audioUtils-C4lyMt3M.js (new) 1.41 kB 🔴 +1.41 kB 🔴 +651 B 🔴 +549 B

Status: 1 added / 1 removed

Vendor & Third-Party — 9.12 MB (baseline 9.12 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-chart-KBsqeQPQ.js 452 kB 452 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-other-CzYzbUcM.js 3.89 MB 3.89 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-primevue-Ch6rhmJJ.js 1.95 MB 1.95 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-DYL0ZbEr.js 2.02 MB 2.02 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-tiptap-XfQ74oRB.js 232 kB 232 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-vue-DLbRHZS7.js 160 kB 160 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-BF8peZ5_.js 420 kB 420 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Other — 3.47 MB (baseline 3.47 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/SubscriptionRequiredDialogContent-B6XesTXz.js (new) 29 kB 🔴 +29 kB 🔴 +6.42 kB 🔴 +5.59 kB
assets/SubscriptionRequiredDialogContent-BqEj5uu9.js (removed) 29 kB 🟢 -29 kB 🟢 -6.43 kB 🟢 -5.59 kB
assets/WidgetRecordAudio-BanaEoRD.js (new) 20.4 kB 🔴 +20.4 kB 🔴 +5.24 kB 🔴 +4.63 kB
assets/WidgetRecordAudio-BPj0TU6y.js (removed) 20.4 kB 🟢 -20.4 kB 🟢 -5.24 kB 🟢 -4.63 kB
assets/AudioPreviewPlayer-41eBK6CX.js (removed) 13.3 kB 🟢 -13.3 kB 🟢 -3.35 kB 🟢 -2.99 kB
assets/AudioPreviewPlayer-DDnATLP8.js (new) 13.3 kB 🔴 +13.3 kB 🔴 +3.35 kB 🔴 +2.99 kB
assets/ValueControlPopover-BJDh1Tru.js (new) 5.49 kB 🔴 +5.49 kB 🔴 +1.71 kB 🔴 +1.51 kB
assets/ValueControlPopover-IgKOrY3a.js (removed) 5.49 kB 🟢 -5.49 kB 🟢 -1.71 kB 🟢 -1.51 kB
assets/WidgetGalleria-D3nhqTr8.js (removed) 4.1 kB 🟢 -4.1 kB 🟢 -1.45 kB 🟢 -1.31 kB
assets/WidgetGalleria-DCQxnCG2.js (new) 4.1 kB 🔴 +4.1 kB 🔴 +1.45 kB 🔴 +1.3 kB
assets/WidgetColorPicker-B3rkxqHY.js (new) 3.41 kB 🔴 +3.41 kB 🔴 +1.39 kB 🔴 +1.23 kB
assets/WidgetColorPicker-B7pr75__.js (removed) 3.41 kB 🟢 -3.41 kB 🟢 -1.38 kB 🟢 -1.23 kB
assets/WidgetTextarea-C8VW346x.js (new) 3.08 kB 🔴 +3.08 kB 🔴 +1.22 kB 🔴 +1.08 kB
assets/WidgetTextarea-m31xbQOD.js (removed) 3.08 kB 🟢 -3.08 kB 🟢 -1.22 kB 🟢 -1.08 kB
assets/WidgetMarkdown-BaVxUtvg.js (new) 3.08 kB 🔴 +3.08 kB 🔴 +1.28 kB 🔴 +1.13 kB
assets/WidgetMarkdown-CezcGSYR.js (removed) 3.08 kB 🟢 -3.08 kB 🟢 -1.28 kB 🟢 -1.13 kB
assets/WidgetAudioUI-BfQaxquD.js (new) 2.89 kB 🔴 +2.89 kB 🔴 +1.17 kB 🔴 +1.06 kB
assets/WidgetAudioUI-CAclVmP7.js (removed) 2.89 kB 🟢 -2.89 kB 🟢 -1.17 kB 🟢 -1.06 kB
assets/WidgetInputText-7-JzKrkV.js (removed) 1.99 kB 🟢 -1.99 kB 🟢 -925 B 🟢 -863 B
assets/WidgetInputText-CJNV2Wza.js (new) 1.99 kB 🔴 +1.99 kB 🔴 +924 B 🔴 +861 B
assets/WidgetToggleSwitch-BtxCJj-Q.js (new) 1.76 kB 🔴 +1.76 kB 🔴 +836 B 🔴 +734 B
assets/WidgetToggleSwitch-lmxGyu16.js (removed) 1.76 kB 🟢 -1.76 kB 🟢 -838 B 🟢 -733 B
assets/MediaImageBottom-CXW3-LJ9.js (removed) 1.55 kB 🟢 -1.55 kB 🟢 -736 B 🟢 -640 B
assets/MediaImageBottom-DjpQ6GU-.js (new) 1.55 kB 🔴 +1.55 kB 🔴 +734 B 🔴 +638 B
assets/MediaAudioBottom-BIOXK2m5.js (new) 1.51 kB 🔴 +1.51 kB 🔴 +735 B 🔴 +645 B
assets/MediaAudioBottom-C1HOqtxz.js (removed) 1.51 kB 🟢 -1.51 kB 🟢 -734 B 🟢 -644 B
assets/Media3DBottom-D9R9pXYm.js (removed) 1.5 kB 🟢 -1.5 kB 🟢 -734 B 🟢 -645 B
assets/Media3DBottom-DNQtCSzg.js (new) 1.5 kB 🔴 +1.5 kB 🔴 +731 B 🔴 +645 B
assets/MediaVideoBottom-BN7KlIk4.js (removed) 1.5 kB 🟢 -1.5 kB 🟢 -733 B 🟢 -646 B
assets/MediaVideoBottom-Dtz0gqaJ.js (new) 1.5 kB 🔴 +1.5 kB 🔴 +730 B 🔴 +648 B
assets/Media3DTop-BnlayFXN.js (new) 1.49 kB 🔴 +1.49 kB 🔴 +767 B 🔴 +653 B
assets/Media3DTop-DAWBFLAT.js (removed) 1.49 kB 🟢 -1.49 kB 🟢 -771 B 🟢 -650 B
assets/WidgetSelect-BKDgvucH.js (removed) 733 B 🟢 -733 B 🟢 -365 B 🟢 -331 B
assets/WidgetSelect-CTOqC_6E.js (new) 733 B 🔴 +733 B 🔴 +364 B 🔴 +320 B
assets/WidgetInputNumber-98VjYao_.js (removed) 673 B 🟢 -673 B 🟢 -349 B 🟢 -289 B
assets/WidgetInputNumber-BLZkMIh3.js (new) 673 B 🔴 +673 B 🔴 +350 B 🔴 +289 B
assets/Load3D-C14xAYbr.js (new) 424 B 🔴 +424 B 🔴 +269 B 🔴 +222 B
assets/Load3D-tmf1t7_0.js (removed) 424 B 🟢 -424 B 🟢 -267 B 🟢 -222 B
assets/WidgetLegacy-B_3W6-x4.js (removed) 364 B 🟢 -364 B 🟢 -238 B 🟢 -195 B
assets/WidgetLegacy-DRI3SCwF.js (new) 364 B 🔴 +364 B 🔴 +239 B 🔴 +194 B
assets/commands-bTEY9Mp6.js 13.8 kB 13.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BWp4HdfU.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CcfGaui5.js 14.4 kB 14.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CisfgZf5.js 13.7 kB 13.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CkU12Foh.js 13 kB 13 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CoH2DJa6.js 14.2 kB 14.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-COSt-Bjx.js 14.9 kB 14.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DalfIW5f.js 15.9 kB 15.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DfTl0eCm.js 13.5 kB 13.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DwSJL865.js 13.7 kB 13.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Bdc58rJq.js 97.1 kB 97.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BRKE6VDs.js 91 kB 91 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-C9ZJBRdI.js 81.5 kB 81.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CAL83XT3.js 84.6 kB 84.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CHLLfvpG.js 82.4 kB 82.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Cw9RZWRY.js 89 B 89 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DDqR5EuX.js 71.3 kB 71.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DLHyaEcz.js 92.1 kB 92.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-O7KfJeMO.js 79.9 kB 79.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-OzGsrlqJ.js 112 kB 112 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaAudioTop-DnMHwvAw.js 1.46 kB 1.46 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaImageTop-BenufCTB.js 1.75 kB 1.75 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaVideoTop-uhl1tYxE.js 2.65 kB 2.65 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-aW9En70v.js 260 kB 260 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BIckSVgU.js 273 kB 273 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BiYpVi7D.js 263 kB 263 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Bw_Jitw_.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CCEXtYfM.js 243 kB 243 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CvmVDWYd.js 323 kB 323 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-D_wreoPJ.js 267 kB 267 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DIAYlJwM.js 246 kB 246 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Dz-0ZIBN.js 297 kB 297 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-VZsNmhG7.js 264 kB 264 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetChart-CXIOBBuD.js 2.48 kB 2.48 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetImageCompare-DOO74J4Y.js 3.18 kB 3.18 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js 1.28 kB 1.28 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 20 added / 20 removed

@jtydhr88 jtydhr88 merged commit 832588c into main Jan 5, 2026
32 checks passed
@jtydhr88 jtydhr88 deleted the fix/3d-animation-continue-rendering branch January 5, 2026 23:07
@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.36 labels Jan 13, 2026
github-actions Bot pushed a commit that referenced this pull request Jan 13, 2026
## Summary

Previously, the 3D viewer would pause rendering when the mouse left the
node to save resources. This caused GLB/FBX animations to freeze when
the user moved the mouse away, which was a poor user experience.

Now the renderer stays active while an animation is playing, and only
pauses when the animation is stopped.

fix #7827

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7836-fix-continue-rendering-when-3D-animation-is-playing-2de6d73d365081a6a365f6c0ccfce7b4)
by [Unito](https://www.unito.io)
github-actions Bot pushed a commit that referenced this pull request Jan 13, 2026
## Summary

Previously, the 3D viewer would pause rendering when the mouse left the
node to save resources. This caused GLB/FBX animations to freeze when
the user moved the mouse away, which was a poor user experience.

Now the renderer stays active while an animation is playing, and only
pauses when the animation is stopped.

fix #7827

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7836-fix-continue-rendering-when-3D-animation-is-playing-2de6d73d365081a6a365f6c0ccfce7b4)
by [Unito](https://www.unito.io)
@comfy-pr-bot
Copy link
Copy Markdown
Member

@jtydhr88 Successfully backported to #7994

@comfy-pr-bot
Copy link
Copy Markdown
Member

@jtydhr88 Successfully backported to #7995

@github-actions github-actions Bot removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Jan 13, 2026
christian-byrne pushed a commit that referenced this pull request Jan 13, 2026
…aying (#7995)

Backport of #7836 to `cloud/1.36`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7995-backport-cloud-1-36-fix-continue-rendering-when-3D-animation-is-playing-2e76d73d3650811fb287cc0f31c5301c)
by [Unito](https://www.unito.io)

Co-authored-by: Terry Jia <terryjia88@gmail.com>
christian-byrne pushed a commit that referenced this pull request Jan 13, 2026
…ying (#7994)

Backport of #7836 to `core/1.36`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7994-backport-core-1-36-fix-continue-rendering-when-3D-animation-is-playing-2e76d73d3650818ca4d4fdf5825f276d)
by [Unito](https://www.unito.io)

Co-authored-by: Terry Jia <terryjia88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3D node animation playback should not be interrupted even when the mouse leaves the node

4 participants