Skip to content

feat: support pip version ComfyUI-Manager#261

Closed
ltdrdata wants to merge 1 commit intomainfrom
dr-support-pip-manager
Closed

feat: support pip version ComfyUI-Manager#261
ltdrdata wants to merge 1 commit intomainfrom
dr-support-pip-manager

Conversation

@ltdrdata
Copy link
Copy Markdown
Member

@ltdrdata ltdrdata commented Apr 27, 2025

modified: Added comfyui_manager to requirements instead of cloning ComfyUI-Manager
modified: Execute python -m comfyui_manager.cm_cli instead of cm-cli.sh
modified: Removed unnecessary Manager installation code


requires comfyui_manager>=4.0.1

modified: Added `comfyui_manager` to requirements instead of cloning ComfyUI-Manager
modified: Execute `python -m comfyui_manager.cm_cli` instead of `cm-cli.sh`
modified: Removed unnecessary Manager installation code
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 27, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comfy_cli/command/custom_nodes/cm_cli_util.py 0.00% 1 Missing ⚠️
comfy_cli/command/custom_nodes/command.py 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   44.78%   45.16%   +0.37%     
==========================================
  Files          29       29              
  Lines        2838     2810      -28     
==========================================
- Hits         1271     1269       -2     
+ Misses       1567     1541      -26     
Files with missing lines Coverage Δ
comfy_cli/cmdline.py 47.84% <ø> (ø)
comfy_cli/command/install.py 36.26% <ø> (+3.42%) ⬆️
comfy_cli/constants.py 100.00% <ø> (ø)
comfy_cli/command/custom_nodes/cm_cli_util.py 28.26% <0.00%> (+2.26%) ⬆️
comfy_cli/command/custom_nodes/command.py 38.25% <0.00%> (+0.10%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot Bot added the dependencies Pull requests that update a dependency file label Apr 27, 2025
@ltdrdata ltdrdata changed the title draft: support pip version ComfyUI-Manager feat: support pip version ComfyUI-Manager Apr 27, 2025
@ltdrdata
Copy link
Copy Markdown
Member Author

Following PR will cover this.
#363

@ltdrdata ltdrdata closed this Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant