You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(desktop): document the example workflow picker and fix the warm-up run range - #2246
installation/desktop/usage/performance-tests.mdx in EN, zh, ja, ko and es.
Warm-up run range corrected: the field takes 0 to 5, and 0 skips the warm-up. Checked against the running app (min=0, max=5 on the input).
"Choose a workflow" cut down: the four dense paragraphs became three short ones, and the bundled example table (stale every release) is gone.
Three screenshots, captured from Comfy Desktop v1.1.8 on macOS:
performance_tests_02_example_workflows.png (replaced): modality tabs, per-card download size, and the Downloaded tooltip on a card whose models are already on disk.
performance_tests_03_example_download.png (new): the drop zone mid-download, Run disabled, the trash button tooltipped Cancel download.
performance_tests_04_disk_warning.png (new): the disk warning above the cards, Use workflow disabled.
Sources
src/renderer/src/views/PerformanceTestView.vue: warm-up clamp correctRunCount(value, 0, 5, 1), canRun excluding an example download, drop-zone progress.
src/renderer/src/components/TemplatePickerStep.vue: the hard-drive icon whose tooltip reads Downloaded, the disk warning above the cards.
src/main/lib/performanceTestExampleWorkflows.ts: modelsPresent and the free space of the models dir.
The performance test guides in five locales now describe workspace-scoped instance lists and expanded example workflow selection and downloads. The warm-up range now starts at zero, which skips warm-up runs.
The guides state that the instance list is filtered by the selected workspace. Translated pages also update panel image descriptions or narrow-window layout details.
Example workflow selection and downloads installation/desktop/usage/performance-tests.mdx, es/installation/desktop/usage/performance-tests.mdx, ja/installation/desktop/usage/performance-tests.mdx, ko/installation/desktop/usage/performance-tests.mdx, zh/installation/desktop/usage/performance-tests.mdx
The guides describe example categories, model download status and controls, picker requirements, failure handling, and behavior when switching instances.
Warm-up settings and translation updates installation/desktop/usage/performance-tests.mdx, es/installation/desktop/usage/performance-tests.mdx, ja/installation/desktop/usage/performance-tests.mdx, ko/installation/desktop/usage/performance-tests.mdx, zh/installation/desktop/usage/performance-tests.mdx
Warm-up runs now allow a minimum of zero, which skips warm-up. Translated pages update translation hashes; the Chinese page also translates button labels and updates the measurement-step heading.
Possibly related PRs
Comfy-Org/docs#2103: Adds the Spanish version of the performance test guide updated here.
Comfy-Org/docs#2070: Creates the Spanish locale and adds the guide updated here.
Comfy-Org/docs#2101: Reverts the Spanish locale containing the guide updated here.
Merge Risk: Minimal · up to a76dc
The documentation clarifies workspace selection, example downloads, and zero warm-up runs. No concrete merge-blocking issue is established; compatibility of the Spanish picker labels remains unverified.
Pre-merge checks: 2
Check name
Status
Explanation
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Simplify code
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Unverified finding
We couldn't verify this from the code. It is shown for review, not as a verified issue.
The new Spanish instructions give translated picker control labels, while the same guide identifies the existing run controls as Run and Stop. If the Spanish Desktop picker also uses English labels, the newly translated labels will not identify clickable controls.
The reader cannot match Elegir un flujo de trabajo de ejemplo or Usar flujo de trabajo to the displayed controls.
This can occur when: A reader follows the Spanish guide in a Desktop installation whose picker labels remain in English.
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 92946493-ecb6-45f3-8950-b05a2fe64049
Commits
Reviewing files that changed from the base of the PR and between 33b68e3 and a76dc77.
Files ignored due to path filters: 3
images/desktop/usage/performance_tests_02_example_workflows.png is excluded by !**/*.png
images/desktop/usage/performance_tests_03_example_download.png is excluded by !**/*.png
images/desktop/usage/performance_tests_04_disk_warning.png is excluded by !**/*.png
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
What changed
installation/desktop/usage/performance-tests.mdxin EN, zh, ja, ko and es.min=0,max=5on the input).performance_tests_02_example_workflows.png(replaced): modality tabs, per-card download size, and the Downloaded tooltip on a card whose models are already on disk.performance_tests_03_example_download.png(new): the drop zone mid-download, Run disabled, the trash button tooltipped Cancel download.performance_tests_04_disk_warning.png(new): the disk warning above the cards, Use workflow disabled.Sources
src/renderer/src/views/PerformanceTestView.vue: warm-up clampcorrectRunCount(value, 0, 5, 1),canRunexcluding an example download, drop-zone progress.src/renderer/src/components/TemplatePickerStep.vue: the hard-drive icon whose tooltip readsDownloaded, the disk warning above the cards.src/main/lib/performanceTestExampleWorkflows.ts:modelsPresentand the free space of the models dir.Checks
check-i18n-syncpasses.##4,###9, fences 2, images 7.installation/desktop/**andimages/desktop/usage/**.