cvxpy bug patch - #1404
Open
j-c-c wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1404 +/- ##
========================================
Coverage 90.66% 90.66%
========================================
Files 135 135
Lines 14930 14931 +1
========================================
+ Hits 13536 13537 +1
Misses 1394 1394 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like
cvxpydoes a lazy evaluation and recomputes some array shapes by summing some uninitialized arrays. This tickles the same bug from #1402. I've moved thoesolveinside the filter and filtered out an additional overflow warning that is sometimes triggered in addition to the invalid values warning. Ran the failing test 200 times using the same ampere testing environment. Should be all good now.