Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support enable date on non-PV node in alarm config #3809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Support enable date on non-PV node in alarm config #3809
Changes from all commits
adb3affc38d2e4a6e4e14c3496cc1b260f2File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 18 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make configure a static final constant or non-public and provide accessors if needed.
Check warning on line 18 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make this "public static configure" field final
Check warning on line 19 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make delayTooltip0 a static final constant or non-public and provide accessors if needed.
Check warning on line 19 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make this "public static delayTooltip0" field final
Check warning on line 20 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make delayTooltip1 a static final constant or non-public and provide accessors if needed.
Check warning on line 20 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make this "public static delayTooltip1" field final
Check warning on line 21 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make delayTooltip2 a static final constant or non-public and provide accessors if needed.
Check warning on line 21 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make this "public static delayTooltip2" field final
Check warning on line 23 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make disableAlarms a static final constant or non-public and provide accessors if needed.
Check warning on line 23 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make this "public static disableAlarms" field final
Check warning on line 27 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make this "public static enableAlarms" field final
Check warning on line 27 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make enableAlarms a static final constant or non-public and provide accessors if needed.
Check warning on line 28 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make headerAlreadyDisabled a static final constant or non-public and provide accessors if needed.
Check warning on line 28 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make this "public static headerAlreadyDisabled" field final
Check warning on line 29 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make this "public static headerAlreadyEnabled" field final
Check warning on line 29 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make headerAlreadyEnabled a static final constant or non-public and provide accessors if needed.
Check warning on line 30 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make this "public static headerConfirmDisable" field final
Check warning on line 30 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make headerConfirmDisable a static final constant or non-public and provide accessors if needed.
Check warning on line 31 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make headerConfirmDisableWithEnableDate a static final constant or non-public and provide accessors if needed.
Check warning on line 31 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make this "public static headerConfirmDisableWithEnableDate" field final
Check warning on line 32 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make headerConfirmEnable a static final constant or non-public and provide accessors if needed.
Check warning on line 32 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make this "public static headerConfirmEnable" field final
Check warning on line 35 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make this "public static promptTitle" field final
Check warning on line 35 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make promptTitle a static final constant or non-public and provide accessors if needed.
Check warning on line 36 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make promptContent a static final constant or non-public and provide accessors if needed.
Check warning on line 36 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java
Make this "public static promptContent" field final
Check failure on line 69 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ComponentConfigDialogController.java
"enabled" is the name of a field in "ConfigDialogController".
Check failure on line 76 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ComponentConfigDialogController.java
"relativeDate" is the name of a field in "ConfigDialogController".
Check failure on line 80 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ComponentConfigDialogController.java
"enabledDatePicker" is the name of a field in "ConfigDialogController".
Check warning on line 94 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ComponentConfigDialogController.java
Add the "@Override" annotation above this method signature
Check warning on line 204 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ComponentConfigDialogController.java
Replace this instanceof check and cast with 'instanceof AlarmClientLeaf pv'
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.