PreferenceReader: Log undefined properties at FINE level#3811
Merged
Conversation
... instead of SEVERE because it tends to not be a fatal issue. For example, the current initialization of `Locations` routinely logs missing `phoebus.folder.name.preference` and `phoebus.user` properties without any ill outcome, whereas a SEVERE log message would suggest that the application cannot continue in this state.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... instead of SEVERE because it tends to not be a fatal issue. For example, the current initialization of
Locationsroutinely logs missingphoebus.folder.name.preferenceandphoebus.userproperties without any ill outcome, whereas a SEVERE log message would suggest that the application cannot continue in this state.This does fix the immediately visible part of #3810: The SEVERE messages are gone, the CONFIG messages remain, and if one is interested in details, one can enable FINE level logging.