fix: keep integration-test fixtures out of the app database - #504
Merged
Conversation
davidmckayv
marked this pull request as ready for review
September 12, 2026 18:47
davidmckayv
requested review from
MikeRyanDev,
guidovizoso,
mxmzb and
tylerslaton
as code owners
September 12, 2026 18:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests could write fixtures into the application database: createDatabase removes DATABASE_URL to avoid a Bun Windows connection bug, and later test files then fell back to localhost/openbot. This left repeated “Raced” components and “removal target” plugins visible after reinstalling the app with its existing database.
Require an explicit, cached TEST_DATABASE_URL and refuse the default application database. All query-backed server tests and the CI test job use that address. Track every fixture in the component/plugin suites and remove it even when the operation under test fails. Most changed files only replace their database URL fallback with the shared helper; production database code is unchanged.
Validation: