Refuse a malformed limit on POST /api/computers/policy-dry-run with 400 - #511
Merged
davidmckayv merged 3 commits intoSep 13, 2026
Merged
Conversation
Ayush7614
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
September 13, 2026 05:10
davidmckayv
approved these changes
Sep 13, 2026
davidmckayv
left a comment
davidmckayv
left a comment
Contributor
There was a problem hiding this comment.
Deep-reviewed clean (validation, no secret leak, fail-closed, agrees with existing layers). CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dry-run read
typeof limit === "number" ? limit : 200and clamped, so string/null/bool silently became 200, Infinity silently became 500, fractions were truncated, and NaN travelled intoauditReader.listas NaN. A what-if answered from the wrong slice of history is worse than no answer.Absent still means the default 200; a present limit must now be a whole number 1..500, else 400
limit must be a whole number between 1 and 500.Policy validation still runs first.Tests: new
server/tests/computer-policy-dry-run-limit.test.ts(17 cases: default window, boundaries 1/200/500, 12 malformed shapes never reaching the reader, malformed policy precedence). Verified: policy route + dry-run engine + new file — 31 pass.