Fixed TextMessage unmarshal JSON#188
Open
virgilio-a-cunha wants to merge 1 commit intoCyCoreSystems:mainfrom
Open
Fixed TextMessage unmarshal JSON#188virgilio-a-cunha wants to merge 1 commit intoCyCoreSystems:mainfrom
virgilio-a-cunha wants to merge 1 commit intoCyCoreSystems:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TextMessageData.Variables field is currently defined as []TextMessageVariable, but it also needs to support JSON input where variables are provided in a map/object format, for example:
"variables": {
"key": "value"
}
as documented
Currently, when the TextMessageReceived event includes variables in this object format, JSON unmarshalling fails, causing the event to be dropped.
This PR adds a custom UnmarshalJSON method for the TextMessageData struct to convert JSON object-style variables into the expected slice format.
It also maintains backward compatibility with the existing JSON array structure.
This change is