Skip to content

Feat/crypto registry aes gcm siv #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mehrn0ush wants to merge 3 commits into
base: master
Choose a base branch
from
+17 −7
Open

Feat/crypto registry aes gcm siv #759

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e67374
fix(registry): remove duplicate BLAKE2b-HMAC variant (#752)
Mehrn0ush Dec 30, 2025
67078ba
feat(registry): add XChaCha20-Poly1305 AEAD variant
Mehrn0ush Dec 30, 2025
980596b
feat(registry): add AES-GCM-SIV AEAD variant
Mehrn0ush Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions schema/cryptography-defs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,16 @@
"pattern": "AES[-(128|192|256)][-(GCM|CCM)][-{tagLength}][-{ivLength}]",
"primitive": "ae"
},
{
"standard": [
{
"name": "RFC 8452",
"url": "https://doi.org/10.17487/RFC8452"
}
],
"pattern": "AES[-(128|192|256)]-GCM-SIV[-{tagLength}][-{ivLength}]",
Copy link
Contributor

@bhess bhess Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the RFC, I understand that in AES-GCM-SIV the tagLength and ivLength are fixed at 16 bytes and 12 bytes, respectively. Since these values are well-defined by the RFC, the [-{tagLength}][-{ivLength}] portion can be removed from the pattern.

"primitive": "ae"
},
{
"standard": [
{
Expand Down Expand Up @@ -468,6 +478,10 @@
{
"pattern": "ChaCha20-Poly1305",
"primitive": "ae"
},
{
"pattern": "XChaCha20-Poly1305",
"primitive": "ae"
Comment on lines +481 to +484
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of XChaCha20-Poly1305 is not mentioned in the PR description or issue #758. This change should either be removed from this PR and submitted separately with appropriate justification, or the PR description should be updated to explain why this variant is being added.

Suggested change
},
{
"pattern": "XChaCha20-Poly1305",
"primitive": "ae"

Copilot uses AI. Check for mistakes.
}
]
},
Expand Down Expand Up @@ -933,10 +947,6 @@
{
"pattern": "BLAKE2s-(160|256)",
"primitive": "hash"
},
{
"pattern": "BLAKE2b-(160|256|384|512)-HMAC",
"primitive": "mac"
}
Comment on lines 947 to 950
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the BLAKE2b-HMAC variant (lines 944-946 in the original) is not mentioned in the PR description or issue #758. This deletion should either be reverted and submitted in a separate PR with appropriate justification, or the PR description should be updated to explain why this variant is being removed.

Copilot uses AI. Check for mistakes.
]
},
Expand Down Expand Up @@ -1018,11 +1028,11 @@
],
"variant": [
{
"pattern": "TUAC[-MAC]",
"pattern": "TUAK[-MAC]",
"primitive": "mac"
},
{
"pattern": "TUAC[-KDF]",
"pattern": "TUAK[-KDF]",
"primitive": "kdf"
}
]
Expand Down Expand Up @@ -1407,7 +1417,7 @@
],
"variant": [
{
"pattern": "bcrypt[-{cost)]",
"pattern": "bcrypt[-{cost}]",
"primitive": "hash"
}
]
Expand Down