Skip to content

feat(registry): add AES-SIV AEAD variant (RFC 5297) #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mehrn0ush wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

feat(registry): add AES-SIV AEAD variant (RFC 5297) #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions schema/cryptography-defs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,16 @@
"pattern": "AES[-(128|192|256)][-(GCM|CCM)][-{tagLength}][-{ivLength}]",
"primitive": "ae"
},
{
"standard": [
{
"name": "RFC 5297",
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RFC naming format is inconsistent with most other RFC references in this file. The majority of RFC references use no space (e.g., 'RFC5649' at line 354, 'RFC5869' at line 375, 'RFC8017', 'RFC2104'), while this uses 'RFC 5297' with a space. Although this matches the nearby 'RFC 5116' and 'RFC 3610' references within the AES family, consider using the more common format 'RFC5297' without a space for consistency across the entire file.

Suggested change
"name": "RFC 5297",
"name": "RFC5297",

Copilot uses AI. Check for mistakes.
"url": "https://doi.org/10.17487/RFC5297"
}
],
"pattern": "AES[-(128|192|256)]-SIV",
"primitive": "ae"
},
{
"standard": [
{
Expand Down