feat(registry): add AES-CMAC-PRF-128 (RFC 4615) #768
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mehrn0ush <[email protected]>
Member
stevespringett
added
cap: cryptography
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for two new cryptographic algorithms to the registry: HPKE (Hybrid Public Key Encryption, RFC 9180) and AES-CMAC-PRF-128 (RFC 4615). However, the PR title and description only mention AES-CMAC-PRF-128, omitting the HPKE addition.
Changes:
- Added HPKE algorithm family with RFC 9180 standard reference
- Added AES-CMAC-PRF-128 variant under the existing AES family with RFC 4615 standard reference
Comments suppressed due to low confidence (2)
schema/cryptography-defs.json:11
- Trailing whitespace after the closing brace and comma. This is inconsistent with the formatting used elsewhere in the file where closing braces have no trailing spaces.
},
schema/cryptography-defs.json:11
- Trailing whitespace after the closing brace and comma. This is inconsistent with the formatting used elsewhere in the file where closing braces have no trailing spaces.
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in ticket #767, this PR adds AES-CMAC-PRF-128 (RFC 4615) to the Cryptography Registry.
Fixes #767
Details
AES-CMAC-PRF-128as amacvariant under the existingAESfamily.schema/cryptography-defs.json). No schema or specification behavior changes.