Skip to content

Migrate modpacks from 1.21.11 to Minecraft 26.1#21

Merged
rubensworks merged 3 commits intomasterfrom
copilot/update-modpacks-to-26-1
Apr 7, 2026
Merged

Migrate modpacks from 1.21.11 to Minecraft 26.1#21
rubensworks merged 3 commits intomasterfrom
copilot/update-modpacks-to-26-1

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 7, 2026 •
edited
Loading

  • Research all mod versions for Minecraft 26.1 (mc version 26.1.1)
  • Delete 1.21.11 directories and create 26.1.1 modpack directories:
    • modpacks/cyclops-all/26.1.1/neoforge/pom.xml
    • modpacks/cyclops-all/26.1.1/fabric/pom.xml
    • modpacks/cyclops-all/26.1.1/forge/pom.xml
    • modpacks/cyclops-id/26.1.1/neoforge/pom.xml
  • Update gametests.yml:
    • Replace 1.21.11 with 26.1.1 (correct full MC version)
    • Add fabric-api/fabric-gametest-api for 26.1.1
    • Change java-version: 21 → java-version: 25 (MC 26.1.1 requires Java 25)
    • Update mc-runtime-test@4.3.0 → @4.3.1 (adds 26.1.1 support + cache fix)
    • Remove matrix.mc != '26.1.1' from client test condition (26.1.1 works for client tests)
    • Update cyclops-all-deps exclusion to mc: 26.1.1
  • Fix pom.xml <version> tag from 26.1 to 26.1.1

rubensworks
rubensworks requested changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@rubensworks rubensworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI for this PR fails at different places. Please analyze and fix.

.github/workflows/gametests.yml Outdated
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: 'Test in runtime client'
if: matrix.env == 'client' && (matrix.loader != 'forge' && matrix.loader != 'fabric' && matrix.mc != '1.21.11') # This does not work yet on Forge, Fabric, or 1.21.11 (all loaders)
if: matrix.env == 'client' && (matrix.loader != 'forge' && matrix.loader != 'fabric' && matrix.mc != '26.1') # This does not work yet on Forge, Fabric, or 26.1 (all loaders)
Copy link
Copy Markdown
Member

@rubensworks rubensworks Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'26.1' can be excluded from this if-condition.

Copy link
Copy Markdown
Contributor Author

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in commit 788bb1a — removed the matrix.mc != '26.1.1' exclusion so client tests now run for 26.1.1 NeoForge.

@rubensworks
Fix CI failures: use mc 26.1.1, java 25, mc-runtime-test 4.3.1, remov…
788bb1a 
…e 26.1 client test exclusion

Agent-Logs-Url: https://github.com/CyclopsMC/packtests/sessions/56215e04-9aa9-468c-b9cb-6106b4ca970d

Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 7, 2026

CI for this PR fails at different places. Please analyze and fix.

Fixed in commit 788bb1a. The failures had four root causes:

  1. Wrong MC version (26.1 → 26.1.1): The actual full Minecraft version ID is 26.1.1, not 26.1. Using 26.1 caused a 404 when downloading fabric-api-0.145.3+26.1.jar (correct artifact is +26.1.1), and Forge's version check requires minecraft 26.1.1 or above to fail.

  2. Java 21 insufficient for MC 26.1.1 (java-version: 21 → java-version: 25): The mods target Java 25 bytecode, and NeoForge 26.1.1 itself requires Java 25. With Java 21, HeadlessMC's "launch for EULA" step failed silently causing the "EULA could not be found" error. Java 25 is backwards-compatible so 1.21.1 tests still work.

  3. Updated mc-runtime-test@4.3.0 → @4.3.1: The renovate bot had already opened a PR updating this; 4.3.1 adds explicit 26.1.1 support and fixes a build cache issue.

  4. Removed matrix.mc != '26.1.1' from client test condition (per inline review comment).

@rubensworks
Fix pom.xml version from 26.1 to 26.1.1
ceaa70d 
Agent-Logs-Url: https://github.com/CyclopsMC/packtests/sessions/56215e04-9aa9-468c-b9cb-6106b4ca970d

Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot AI requested a review from rubensworks April 7, 2026 12:03
@rubensworks rubensworks marked this pull request as ready for review April 7, 2026 15:04
@rubensworks rubensworks merged commit 41c0421 into master Apr 7, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubensworks rubensworks Awaiting requested review from rubensworks

Assignees

@rubensworks rubensworks

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rubensworks