added an octave manager for more complex(?) RTTTL#2
Open
PlantLily wants to merge 4 commits intoDDRBoxman:masterfrom
Open
added an octave manager for more complex(?) RTTTL#2PlantLily wants to merge 4 commits intoDDRBoxman:masterfrom
PlantLily wants to merge 4 commits intoDDRBoxman:masterfrom
Conversation
DDRBoxman
requested changes
May 8, 2017
|
|
||
|
|
||
| //octave manager | ||
| if(isNaN(oct) == false){ |
Author
There was a problem hiding this comment.
alright added oct to it
and changed the refinement of octave, sorry I'm really tired
main.js
Outdated
| if(isNaN(oct) == false){ | ||
| octave = octave*1 + (oct*1-octave*1); | ||
| }else{ | ||
| var octave = settings.getOctave(); |
Owner
There was a problem hiding this comment.
this shouldn't redefine octave within the else scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just a very simple octave changing snippet