Skip to content

Feature/DF-861: Geospatial component #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidjamesstone wants to merge 61 commits into
base: main
Choose a base branch
from

Add convenient "id" properties to the page and component base classes

46d411a
Select commit
Loading
Failed to load commit list.
Open

Feature/DF-861: Geospatial component #321

Add convenient "id" properties to the page and component base classes
46d411a
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 19, 2026 in 49s

Quality Gate passed

Issues
6 New issues
2 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 283 in src/client/javascripts/geospatial-map.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use null instead. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_forms-engine-plugin&issues=AZzhVJGcM9Y8niPcfv_9&open=AZzhVJGcM9Y8niPcfv_9&pullRequest=321

Check warning on line 253 in src/client/javascripts/map.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_forms-engine-plugin&issues=AZzD0PpF7uAT7oIqgAPv&open=AZzD0PpF7uAT7oIqgAPv&pullRequest=321

Check warning on line 92 in src/client/javascripts/geospatial-map.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_forms-engine-plugin&issues=AZzD0PmN7uAT7oIqgAPr&open=AZzD0PmN7uAT7oIqgAPr&pullRequest=321

Check warning on line 212 in src/client/javascripts/map.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_forms-engine-plugin&issues=AZzD0PpF7uAT7oIqgAPu&open=AZzD0PpF7uAT7oIqgAPu&pullRequest=321

Check warning on line 251 in src/client/javascripts/geospatial-map.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_forms-engine-plugin&issues=AZzD0PmN7uAT7oIqgAPp&open=AZzD0PmN7uAT7oIqgAPp&pullRequest=321

Check warning on line 162 in src/client/javascripts/map.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_forms-engine-plugin&issues=AZzD0PpF7uAT7oIqgAPt&open=AZzD0PpF7uAT7oIqgAPt&pullRequest=321
View more details on SonarQubeCloud