Merged
Conversation
search for each index and for indices out of range and check return value
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2114 +/- ##
=======================================
Coverage 77.41% 77.42%
=======================================
Files 113 113
Lines 19178 19178
=======================================
+ Hits 14847 14848 +1
+ Misses 4331 4330 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
holke
requested changes
Jan 27, 2026
Collaborator
holke
left a comment
There was a problem hiding this comment.
Cool addition. Looks good up to minor corrections.
Co-authored-by: Johannes Holke <johannes.holke@dlr.de>
holke
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1726
adds a test for the shmem binary search.
Initializes a shared memory array where each entry is set to its index.
Then searches for each index and compares for equality.
Additionally searches for values outside of the range to check if -1 is returned.
Found an error and fixed it.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).