Skip to content

fix(dts): remove duplicate network wait prompt in deploy workflows#152

Open
fujijin wants to merge 1 commit intoDasharo:mainfrom
fujijin:bounty-1219-network-message
Open

fix(dts): remove duplicate network wait prompt in deploy workflows#152
fujijin wants to merge 1 commit intoDasharo:mainfrom
fujijin:bounty-1219-network-message

Conversation

@fujijin
Copy link

@fujijin fujijin commented Mar 19, 2026

Summary\n- remove early network wait check from to avoid duplicated prompt\n- run at concrete download points in and \n- add network check before cloud HCL lookup in \n\n## Why\nIssue #1219 reports repeated "Waiting for network connection" message.\n\n## Validation\n- syntax check: \n- reviewed flow to keep download-time checks in deploy paths\n\nCloses Dasharo/dasharo-issues#1219

@fujijin
Copy link
Author

fujijin commented Mar 19, 2026

Summary

  • remove early network wait check from board_config() to avoid duplicated prompt
  • run wait_for_network_connection true at concrete download points in install_workflow() and update_workflow()
  • add network check before cloud HCL lookup in restore()

Why

Issue #1219 reports repeated "Waiting for network connection" message.

Validation

  • syntax check: bash -n include/dts-functions.sh scripts/dasharo-deploy.sh
  • reviewed flow to keep download-time checks in deploy paths

Closes Dasharo/dasharo-issues#1219

@fujijin
Copy link
Author

fujijin commented Mar 21, 2026

Ready-for-review follow-up:\n\n- removed duplicate early network wait prompt path\n- kept wait checks at actual download points in deploy/update flows\n- added restore-path network check before cloud HCL lookup\n\nPlease share any scenario where the prompt still appears twice and I’ll patch promptly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant