fix(dts): remove duplicate network wait prompt in deploy workflows#152
Open
fujijin wants to merge 1 commit intoDasharo:mainfrom
Open
fix(dts): remove duplicate network wait prompt in deploy workflows#152fujijin wants to merge 1 commit intoDasharo:mainfrom
fujijin wants to merge 1 commit intoDasharo:mainfrom
Conversation
Author
Summary
WhyIssue #1219 reports repeated "Waiting for network connection" message. Validation
Closes Dasharo/dasharo-issues#1219 |
Author
|
Ready-for-review follow-up:\n\n- removed duplicate early network wait prompt path\n- kept wait checks at actual download points in deploy/update flows\n- added restore-path network check before cloud HCL lookup\n\nPlease share any scenario where the prompt still appears twice and I’ll patch promptly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- remove early network wait check from to avoid duplicated prompt\n- run at concrete download points in and \n- add network check before cloud HCL lookup in \n\n## Why\nIssue #1219 reports repeated "Waiting for network connection" message.\n\n## Validation\n- syntax check: \n- reviewed flow to keep download-time checks in deploy paths\n\nCloses Dasharo/dasharo-issues#1219